r47930 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47929‎ | r47930 | r47931 >
Date:14:17, 2 March 2009
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Fix careless error in suppression on SpecialDeletedContributions.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialDeletedContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialNewpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialNewpages.php
@@ -438,7 +438,12 @@
439439 $fields = array();
440440
441441 ## Modify query for tags
442 - ChangeTags::modifyDisplayQuery( $info['tables'], $fields, $info['conds'], $info['join_conds'], $this->opts['tagfilter'] );
 442+ ChangeTags::modifyDisplayQuery( $info['tables'],
 443+ $fields,
 444+ $info['conds'],
 445+ $info['join_conds'],
 446+ $info['options'],
 447+ $this->opts['tagfilter'] );
443448
444449 return $info;
445450 }
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -287,7 +287,8 @@
288288 }
289289
290290 // Tag stuff.
291 - $fields = array(); // Fields are * in this case, so let the function modify an empty array to keep it happy.
 291+ $fields = array();
 292+ // Fields are * in this case, so let the function modify an empty array to keep it happy.
292293 ChangeTags::modifyDisplayQuery( $tables, $fields, $conds, $join_conds, $opts['tagfilter'] );
293294
294295 wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts ) );
Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -398,7 +398,12 @@
399399 'join_conds' => $join_cond
400400 );
401401
402 - ChangeTags::modifyDisplayQuery( $queryInfo['tables'], $queryInfo['fields'], $queryInfo['conds'], $queryInfo['join_conds'], $this->tagFilter );
 402+ ChangeTags::modifyDisplayQuery( $queryInfo['tables'],
 403+ $queryInfo['fields'],
 404+ $queryInfo['conds'],
 405+ $queryInfo['join_conds'],
 406+ $queryInfo['options'],
 407+ $this->tagFilter );
403408
404409 wfRunHooks( 'ContribsPager::getQueryInfo', array( &$this, &$queryInfo ) );
405410 return $queryInfo;
Index: trunk/phase3/includes/specials/SpecialDeletedContributions.php
@@ -115,7 +115,7 @@
116116 'user_text' => $row->ar_user_text,
117117 'timestamp' => $row->ar_timestamp,
118118 'minor_edit' => $row->ar_minor_edit,
119 - 'rev_deleted' => $row->ar_deleted,
 119+ 'deleted' => $row->ar_deleted,
120120 ) );
121121
122122 $page = Title::makeTitle( $row->ar_namespace, $row->ar_title );

Follow-up revisions

RevisionCommit summaryAuthorDate
r47931Partial revert of r47930, accidentally included half-done changeswerdna14:27, 2 March 2009

Comments

#Comment by Voice of All (talk | contribs)   00:48, 6 March 2009

Fixed in r47931

Status & tagging log