r47931 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47930‎ | r47931 | r47932 >
Date:14:27, 2 March 2009
Author:werdna
Status:ok
Tags:
Comment:
Partial revert of r47930, accidentally included half-done changes
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialNewpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialNewpages.php
@@ -438,12 +438,7 @@
439439 $fields = array();
440440
441441 ## Modify query for tags
442 - ChangeTags::modifyDisplayQuery( $info['tables'],
443 - $fields,
444 - $info['conds'],
445 - $info['join_conds'],
446 - $info['options'],
447 - $this->opts['tagfilter'] );
 442+ ChangeTags::modifyDisplayQuery( $info['tables'], $fields, $info['conds'], $info['join_conds'], $this->opts['tagfilter'] );
448443
449444 return $info;
450445 }
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -287,8 +287,7 @@
288288 }
289289
290290 // Tag stuff.
291 - $fields = array();
292 - // Fields are * in this case, so let the function modify an empty array to keep it happy.
 291+ $fields = array(); // Fields are * in this case, so let the function modify an empty array to keep it happy.
293292 ChangeTags::modifyDisplayQuery( $tables, $fields, $conds, $join_conds, $opts['tagfilter'] );
294293
295294 wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts ) );
Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -398,12 +398,7 @@
399399 'join_conds' => $join_cond
400400 );
401401
402 - ChangeTags::modifyDisplayQuery( $queryInfo['tables'],
403 - $queryInfo['fields'],
404 - $queryInfo['conds'],
405 - $queryInfo['join_conds'],
406 - $queryInfo['options'],
407 - $this->tagFilter );
 402+ ChangeTags::modifyDisplayQuery( $queryInfo['tables'], $queryInfo['fields'], $queryInfo['conds'], $queryInfo['join_conds'], $this->tagFilter );
408403
409404 wfRunHooks( 'ContribsPager::getQueryInfo', array( &$this, &$queryInfo ) );
410405 return $queryInfo;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47930Fix careless error in suppression on SpecialDeletedContributions.werdna14:17, 2 March 2009

Status & tagging log