r47854 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r47853‎ | r47854 | r47855 >
Date:08:11, 27 February 2009
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Add 'action-$right' messages
Modified paths:
  • /trunk/extensions/AbuseFilter/AbuseFilter.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/AbuseFilter.i18n.php
——@@ -58,6 +58,14 @@
5959 'right-abusefilter-modify-restricted' => 'Modify abuse filters with restricted actions',
6060 'right-abusefilter-revert' => 'Revert all changes by a given abuse filter',
6161
 62+ 'action-abusefilter-modify' => 'modify abuse filters',
 63+ 'action-abusefilter-view' => 'view abuse filters',
 64+ 'action-abusefilter-log' => 'view the abuse log',
 65+ 'action-abusefilter-log-detail' => 'view detailed abuse log entries',
 66+ 'action-abusefilter-private' => 'view private data in the abuse log',
 67+ 'action-abusefilter-modify-restricted' => 'modify abuse filters with restricted actions',
 68+ 'action-abusefilter-revert' => 'revert all changes by a given abuse filter',
 69+
6270 // Abuse Log
6371 'abusefilter-log' => 'Abuse filter log',
6472 'abusefilter-log-search' => 'Search the abuse log',

Comments

#Comment by Siebrand (talk | contribs)   09:28, 27 February 2009

These 'action-$right' messages are only needed if they will ever be used. Andrew explained to me a while ago that these are only used in OutputPage::formatPermissionsErrorMessage(), and only when an action is specified. OutputPage::showPermissionsErrorPage() and OutputPage::readOnlyPage() also reference this method. Can you confirm that AbuseFilter actually does this? If not, these messages are not needed, because never used.

Side note: mea culpa, because I also added these messages to extensions. All current 'action-$right' messages should be checked for actual possible usage, and if not found, be removed. This also goes for core.

#Comment by Raymond (talk | contribs)   09:34, 27 February 2009

I stumbled today over the missing message "action-abusefilter-log" on my own testwiki. Will check the other action messages...

Status & tagging log