r47853 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47852‎ | r47853 | r47854 >
Date:07:13, 27 February 2009
Author:purodha
Status:ok
Tags:
Comment:
(bug 17692) Added (list of members) link to 'user' in Special:Listgrouprights
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -223,6 +223,7 @@
224224 * (bug 17460) Client ecoding is now correctly set for PostgreSQL
225225 * (bug 17648) Prevent floats from intruding into edit area in previews if no toolbar present
226226 * (bug 16899) DISPLAYTITLE should allow Arabic and Persian harakats
 227+* (bug 17692) Added (list of members) link to 'user' in Special:Listgrouprights
227228
228229 == API changes in 1.15 ==
229230 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions
@@ -345,4 +346,4 @@
346347
347348 === IRC help ===
348349
349 -There's usually someone online in #mediawiki on irc.freenode.net
\ No newline at end of file
 350+There's usually someone online in #mediawiki on irc.freenode.net
Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
@@ -63,10 +63,13 @@
6464 $grouppage = $this->skin->makeLink( $grouppageLocalized, $groupnameLocalized );
6565 }
6666
67 - if ( !in_array( $group, $wgImplicitGroups ) ) {
 67+ if ( $group === 'user' ) {
 68+ // Link to Special:listusers for implicit group 'user'
 69+ $grouplink = '<br />' . $this->skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Listusers' ), wfMsgHtml( 'listgrouprights-members' ), '' );
 70+ } elseif ( !in_array( $group, $wgImplicitGroups ) ) {
6871 $grouplink = '<br />' . $this->skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Listusers' ), wfMsgHtml( 'listgrouprights-members' ), 'group=' . $group );
6972 } else {
70 - // No link to Special:listusers for implicit groups as they are unlistable
 73+ // No link to Special:listusers for other implicit groups as they are unlistable
7174 $grouplink = '';
7275 }
7376

Status & tagging log