r47466 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47465‎ | r47466 | r47467 >
Date:20:00, 18 February 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
(bug 17556) <link> parameters in Special:Contributions feeds (RSS and Atom) now point to the actual contributors' feed.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -266,7 +266,7 @@
267267 return $f;
268268 }
269269
270 - /**
 270+ /**
271271 * Output a subscription feed listing recent edits to this page.
272272 * @param string $type
273273 */
@@ -288,7 +288,7 @@
289289 $feed = new $wgFeedClasses[$type](
290290 $this->feedTitle(),
291291 wfMsgExt( 'tagline', 'parsemag' ),
292 - $this->getTitle()->getFullUrl() );
 292+ $this->getTitle()->getFullUrl() . "/" . htmlspecialchars( $this->opts['target'] ) );
293293
294294 // Already valid title
295295 $nt = Title::makeTitleSafe( NS_USER, $this->opts['target'] );
Index: trunk/phase3/RELEASE-NOTES
@@ -190,6 +190,8 @@
191191 * (bug 14980) Messages 'shareduploadwiki' and 'shareduploadwiki-desc' are now
192192 used as a parameter in 'sharedupload' for easier styling and customization.
193193 * (bug 17482) Formatting error in Special:Preferences#Misc (Opera)
 194+* (bug 17556) <link> parameters in Special:Contributions feeds (RSS and Atom)
 195+ now point to the actual contributors' feed.
194196
195197 == API changes in 1.15 ==
196198 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Follow-up revisions

RevisionCommit summaryAuthorDate
r47731Fix double-escaping from r47466 (feed calls getUrl() which calls xmlEncode() ...aaron23:18, 23 February 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   23:20, 23 February 2009

Double escaping fixed in r47731. urlencode() added.

Status & tagging log