r47541 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r47540‎ | r47541 | r47542 >
Date:11:21, 20 February 2009
Author:nad
Status:reverted (Comments)
Tags:
Comment:
the introduction of the pipeList function on line 38 breaks it on <1.13
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
——@@ -35,10 +35,9 @@
3636 if ( $wpTitle && !ereg( "^$type:.+$", $wpTitle ) ) $wpTitle = "$type:$wpTitle";
3737 }
3838
39 - $wgOut->addHTML( $wgLang->pipeList( array(
40 - "<div class='center'><a href='" . $title->getLocalURL() . "/$type'>" . wfMsg( 'recordadmin-newsearch', $type ) . "</a>",
41 - "<a href='" . $title->getLocalURL() . "'>" . wfMsg( 'recordadmin-newrecord' ) . "</a></div><br>\n"
42 - ) ) );
 39+ $wgOut->addHTML( "<div class='center'><a href='" . $title->getLocalURL() . "/$type'>" . wfMsg( 'recordadmin-newsearch', $type ) . "</a> | "
 40+ . "<a href='" . $title->getLocalURL() . "'>" . wfMsg( 'recordadmin-newrecord' ) . "</a></div><br>\n"
 41+ );
4342
4443 # Get posted form values if any
4544 $posted = array();

Follow-up revisions

RevisionCommit summaryAuthorDate
r47547RecordAdmin: Reapply r47054 (migrate extensions to $wgLang->pipelist()) which...catrope13:41, 20 February 2009

Comments

#Comment by Siebrand (talk | contribs)   11:54, 20 February 2009

This commit is related to r47304 and r47312
So? That's what we have branches for. RecordAdmin has a branch in 1.14 you can make compatible with other versions than trunk. With this commit formatting is hard coded again.

#Comment by Catrope (talk | contribs)   13:41, 20 February 2009

1.13-compatible version tagged in r47546, $wgLang->pipeList() readded in r47547

Status & tagging log