r47547 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r47546‎ | r47547 | r47548 >
Date:13:41, 20 February 2009
Author:catrope
Status:deferred
Tags:
Comment:
RecordAdmin: Reapply r47054 (migrate extensions to $wgLang->pipelist()) which was reverted twice before, in r47304 and in r47541 because of 1.13 compatibility issues. Now that a 1.13-compatible version has been tagged in r47546, it's safe to use 1.14-only functions in trunk.
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
——@@ -35,9 +35,10 @@
3636 if ( $wpTitle && !ereg( "^$type:.+$", $wpTitle ) ) $wpTitle = "$type:$wpTitle";
3737 }
3838
39 - $wgOut->addHTML( "<div class='center'><a href='" . $title->getLocalURL() . "/$type'>" . wfMsg( 'recordadmin-newsearch', $type ) . "</a> | "
40 - . "<a href='" . $title->getLocalURL() . "'>" . wfMsg( 'recordadmin-newrecord' ) . "</a></div><br>\n"
41 - );
 39+ $wgOut->addHTML( $wgLang->pipeList( array(
 40+ "<div class='center'><a href='" . $title->getLocalURL() . "/$type'>" . wfMsg( 'recordadmin-newsearch', $type ) . "</a>",
 41+ "<a href='" . $title->getLocalURL() . "'>" . wfMsg( 'recordadmin-newrecord' ) . "</a></div><br>\n"
 42+ ) ) );
4243
4344 # Get posted form values if any
4445 $posted = array();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47054Replace hard coded pipe separators with locale basedsiebrand21:59, 9 February 2009
r47304rv that last change broke itnad04:12, 16 February 2009
r47541the introduction of the pipeList function on line 38 breaks it on <1.13nad11:21, 20 February 2009
r47546Tagging RecordAdmin version compatible with 1.13.4. I know tags aren't suppos...catrope13:35, 20 February 2009

Status & tagging log