r47392 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47391‎ | r47392 | r47393 >
Date:23:05, 17 February 2009
Author:aaron
Status:deferred (Comments)
Tags:
Comment:
Rename new ACTIVEUSERS word to NUMBEROFACTIVEUSERS
Modified paths:
  • /trunk/phase3/includes/MagicWord.php (modified) (history)
  • /trunk/phase3/includes/parser/CoreParserFunctions.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -2492,7 +2492,7 @@
24932493 return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::images() );
24942494 case 'numberofusers':
24952495 return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::users() );
2496 - case 'activeusers':
 2496+ case 'numberofactiveusers':
24972497 return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::activeUsers() );
24982498 case 'numberofpages':
24992499 return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::pages() );
Index: trunk/phase3/includes/parser/CoreParserFunctions.php
@@ -31,7 +31,7 @@
3232 $parser->setFunctionHook( 'plural', array( __CLASS__, 'plural' ), SFH_NO_HASH );
3333 $parser->setFunctionHook( 'numberofpages', array( __CLASS__, 'numberofpages' ), SFH_NO_HASH );
3434 $parser->setFunctionHook( 'numberofusers', array( __CLASS__, 'numberofusers' ), SFH_NO_HASH );
35 - $parser->setFunctionHook( 'activeusers', array( __CLASS__, 'activeusers' ), SFH_NO_HASH );
 35+ $parser->setFunctionHook( 'numberofactiveusers', array( __CLASS__, 'numberofactiveusers' ), SFH_NO_HASH );
3636 $parser->setFunctionHook( 'numberofarticles', array( __CLASS__, 'numberofarticles' ), SFH_NO_HASH );
3737 $parser->setFunctionHook( 'numberoffiles', array( __CLASS__, 'numberoffiles' ), SFH_NO_HASH );
3838 $parser->setFunctionHook( 'numberofadmins', array( __CLASS__, 'numberofadmins' ), SFH_NO_HASH );
@@ -245,7 +245,7 @@
246246 static function numberofusers( $parser, $raw = null ) {
247247 return self::formatRaw( SiteStats::users(), $raw );
248248 }
249 - static function activeusers( $parser, $raw = null ) {
 249+ static function numberofactiveusers( $parser, $raw = null ) {
250250 return self::formatRaw( SiteStats::activeUsers(), $raw );
251251 }
252252 static function numberofarticles( $parser, $raw = null ) {
Index: trunk/phase3/includes/MagicWord.php
@@ -90,7 +90,7 @@
9191 'subjectpagename',
9292 'subjectpagenamee',
9393 'numberofusers',
94 - 'activeusers',
 94+ 'numberofactiveusers',
9595 'newsectionlink',
9696 'numberofpages',
9797 'currentversion',
@@ -142,7 +142,7 @@
143143 'localweek' => 3600,
144144 'localdow' => 3600,
145145 'numberofusers' => 3600,
146 - 'activeusers' => 3600,
 146+ 'numberofactiveusers' => 3600,
147147 'numberofpages' => 3600,
148148 'currentversion' => 86400,
149149 'currenttimestamp' => 3600,
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -232,7 +232,7 @@
233233 'numberofarticles' => array( 1, 'NUMBEROFARTICLES' ),
234234 'numberoffiles' => array( 1, 'NUMBEROFFILES' ),
235235 'numberofusers' => array( 1, 'NUMBEROFUSERS' ),
236 - 'activeusers' => array( 1, 'ACTIVEUSERS', 'NUMBEROFACTIVEUSERS' ),
 236+ 'numberofactiveusers' => array( 1, 'NUMBEROFACTIVEUSERS' ),
237237 'numberofedits' => array( 1, 'NUMBEROFEDITS' ),
238238 'numberofviews' => array( 1, 'NUMBEROFVIEWS' ),
239239 'pagename' => array( 1, 'PAGENAME' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r47433Follow up r47392: Rename magic word for existing translations tooraymond08:25, 18 February 2009

Comments

#Comment by Werdna (talk | contribs)   23:44, 17 February 2009

You didn't "rename" it, you removed a perfectly functional alias. Why?

#Comment by Remember the dot (talk | contribs)   04:52, 18 February 2009
#Comment by Raymond (talk | contribs)   08:27, 18 February 2009

Follow up r47433: Rename magic word for existing translations too

Status & tagging log