r47393 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47392‎ | r47393 | r47394 >
Date:23:10, 17 February 2009
Author:aaron
Status:deferred
Tags:
Comment:
Simplify code here a tad
Modified paths:
  • /trunk/extensions/CodeReview/CodeReleaseNotes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReleaseNotes.php
@@ -133,7 +133,7 @@
134134
135135 // Quick relevance tests (these *should* be over-inclusive a little if anything)
136136 private function isRelevant( $summary ) {
137 - # Fixed a bug? Mentioned a config var? Mentioned a rev?
 137+ # Fixed a bug? Mentioned a config var?
138138 if( preg_match( '/\b(bug #?(\d+)|\$[we]g[0-9a-z]{3,50})\b/i', $summary ) )
139139 return true;
140140 # Sanity check: summary cannot be *too* short to be useful
@@ -148,9 +148,6 @@
149149 if( preg_match( '/\b(wiki|HTML\d|CSS\d|UTF-?8|(Apache|PHP|CGI|Java|Perl|Python|\w+SQL) ?\d?\.?\d?)\b/i', $summary ) )
150150 return true;
151151 # Longish summary :)
152 - if( $words > 35 )
153 - return true;
154 - # Otherwise false
155 - return false;
 152+ return ( $words > 35 );
156153 }
157154 }

Status & tagging log