r47269 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47268‎ | r47269 | r47270 >
Date:16:00, 14 February 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Cleanup to $wgFeedClasses:
* Remove 2 unused globals
* (bug 17488) Link in toolbar to feeds should be localized (already have the feed-$format messages) Patch by Marcin Cieślak.
* Tangentially, can $wgFeedClasses be moved from Defines to DefaultSettings? Seems to make more sense in the latter.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ChangesFeed.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -67,6 +67,7 @@
6868 * Juliano F. Ravasi
6969 * Lucas Garczewski
7070 * Louperivois
 71+* Marcin Cieślak
7172 * Marooned
7273 * Max Semenik
7374 * Michael De La Rue
Index: trunk/phase3/includes/ChangesFeed.php
@@ -20,7 +20,7 @@
2121
2222 public function execute( $feed, $rows, $limit=0, $hideminor=false, $lastmod=false, $target='' ) {
2323 global $messageMemc, $wgFeedCacheTimeout;
24 - global $wgFeedClasses, $wgSitename, $wgContLanguageCode;
 24+ global $wgSitename, $wgContLanguageCode;
2525
2626 if ( !FeedUtils::checkFeedOutput( $this->format ) ) {
2727 return;
Index: trunk/phase3/includes/SkinTemplate.php
@@ -138,7 +138,7 @@
139139 global $wgScript, $wgStylePath, $wgContLanguageCode;
140140 global $wgMimeType, $wgJsMimeType, $wgOutputEncoding, $wgRequest;
141141 global $wgXhtmlDefaultNamespace, $wgXhtmlNamespaces;
142 - global $wgDisableCounters, $wgLogo, $action, $wgFeedClasses, $wgHideInterlanguageLinks;
 142+ global $wgDisableCounters, $wgLogo, $action, $wgHideInterlanguageLinks;
143143 global $wgMaxCredits, $wgShowCreditsIfMax;
144144 global $wgPageShowWatchingUsers;
145145 global $wgUseTrackbacks, $wgUseSiteJs;
Index: trunk/phase3/includes/Skin.php
@@ -1020,7 +1020,8 @@
10211021 if( $wgOut->isSyndicated() ) {
10221022 foreach( $wgFeedClasses as $format => $class ) {
10231023 $feedurl = $wgRequest->escapeAppendQuery( "feed=$format" );
1024 - $s[] = "<a href=\"$feedurl\" rel=\"alternate\" type=\"application/{$format}+xml\" class=\"feedlink\">{$format}</a>";
 1024+ $s[] = "<a href=\"$feedurl\" rel=\"alternate\" type=\"application/{$format}+xml\""
 1025+ . " class=\"feedlink\">" . wfMsg( "feed-$format" ) . "</a>";
10251026 }
10261027 }
10271028 return $wgLang->pipeList( $s );
Index: trunk/phase3/RELEASE-NOTES
@@ -169,6 +169,7 @@
170170 * (bug 12746) Do not allow new password e-mails when wiki is in read-only mode
171171 * (bug 17478) Fixed a PHP Strict standards error in
172172 maintenance/cleanupWatchlist.php
 173+* (bug 17488) RSS/Atom links in left toolbar are now localized
173174
174175 == API changes in 1.15 ==
175176 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Follow-up revisions

RevisionCommit summaryAuthorDate
r47384Followup to r47269 "* (bug 17488) Link in toolbar to feeds should be localize...brion22:21, 17 February 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:21, 17 February 2009

Followup in r47384 for escaping & notes tweak

Status & tagging log