r47384 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47383‎ | r47384 | r47385 >
Date:22:21, 17 February 2009
Author:brion
Status:ok
Tags:
Comment:
Followup to r47269 "* (bug 17488) Link in toolbar to feeds should be localized (already have the feed-$format messages) Patch by Marcin Cieślak."
* Fixed release notes to clarify this is for classic skin
* HTML-escaping the message to match Monobook behavior
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1021,7 +1021,7 @@
10221022 foreach( $wgFeedClasses as $format => $class ) {
10231023 $feedurl = $wgRequest->escapeAppendQuery( "feed=$format" );
10241024 $s[] = "<a href=\"$feedurl\" rel=\"alternate\" type=\"application/{$format}+xml\""
1025 - . " class=\"feedlink\">" . wfMsg( "feed-$format" ) . "</a>";
 1025+ . " class=\"feedlink\">" . wfMsgHtml( "feed-$format" ) . "</a>";
10261026 }
10271027 }
10281028 return $wgLang->pipeList( $s );
Index: trunk/phase3/RELEASE-NOTES
@@ -177,7 +177,7 @@
178178 * (bug 12746) Do not allow new password e-mails when wiki is in read-only mode
179179 * (bug 17478) Fixed a PHP Strict standards error in
180180 maintenance/cleanupWatchlist.php
181 -* (bug 17488) RSS/Atom links in left toolbar are now localized
 181+* (bug 17488) RSS/Atom links in left toolbar are now localized in classic skin
182182 * (bug 17472) use print <<<EOF in maintenance/importTextFile.php
183183 * Special:PrefixIndex: Move table styling to shared.css, add CSS IDs to tables
184184 use correct message 'allpagesprefix' for input form label, replace _ with ' '

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47269Cleanup to $wgFeedClasses:...demon16:00, 14 February 2009

Status & tagging log