r46675 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46674‎ | r46675 | r46676 >
Date:10:05, 1 February 2009
Author:nikerabbit
Status:deferred (Comments)
Tags:
Comment:
* Fix E_NOTICE for werdnum
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -35,7 +35,7 @@
3636 }
3737
3838 if( !strlen( $target ) ) {
39 - $wgOut->addHTML( $this->getForm( '' ) );
 39+ $wgOut->addHTML( $this->getForm() );
4040 return;
4141 }
4242
@@ -44,7 +44,7 @@
4545
4646 $nt = Title::makeTitleSafe( NS_USER, $target );
4747 if( !$nt ) {
48 - $wgOut->addHTML( $this->getForm( '' ) );
 48+ $wgOut->addHTML( $this->getForm() );
4949 return;
5050 }
5151 $id = User::idFromName( $nt->getText() );
@@ -64,7 +64,7 @@
6565 $this->opts['namespace'] = '';
6666 }
6767
68 - $this->opts['tagfilter'] = $wgRequest->getVal( 'tagfilter' );
 68+ $this->opts['tagfilter'] = (string) $wgRequest->getVal( 'tagfilter' );
6969
7070 // Allows reverts to have the bot flag in recent changes. It is just here to
7171 // be passed in the form at the top of the page
@@ -106,7 +106,7 @@
107107
108108 wfRunHooks( 'SpecialContributionsBeforeMainOutput', $id );
109109
110 - $wgOut->addHTML( $this->getForm( $this->opts ) );
 110+ $wgOut->addHTML( $this->getForm() );
111111
112112 $pager = new ContribsPager( $target, $this->opts['namespace'], $this->opts['year'], $this->opts['month'] );
113113 if( !$pager->getNumRows() ) {
@@ -237,6 +237,10 @@
238238 if( $this->opts['contribs'] == 'newbie' ) {
239239 $this->opts['target'] = '';
240240 }
 241+
 242+ if( !isset( $this->opts['tagfilter'] ) ) {
 243+ $this->opts['tagfilter'] = '';
 244+ }
241245
242246 $f = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) );
243247

Comments

#Comment by Werdna (talk | contribs)   01:20, 12 February 2009

Fix for r46460.

Status & tagging log