r46524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r46523‎ | r46524 | r46525 >
Date:07:01, 29 January 2009
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
Add a newline in front of the message to avoid wrong parsing when the message text starts with line-start-markup such as a table or list.

The missing newline was the real culprit of the breakage seen in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/45651#c1531
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1846,7 +1846,7 @@
18471847 $args = array();
18481848 $name = $spec;
18491849 }
1850 - $s = str_replace( '$' . ($n+1), wfMsgExt( $name, $options, $args ), $s );
 1850+ $s = str_replace( '$' . ( $n + 1 ), "\n" . wfMsgExt( $name, $options, $args ), $s );
18511851 }
18521852 $this->addHTML( $this->parse( $s, /*linestart*/true, /*uilang*/true ) );
18531853 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r46601Revert r46524 per Nikerabbits commentraymond16:45, 30 January 2009

Comments

#Comment by Nikerabbit (talk | contribs)   16:11, 30 January 2009

This breaks titlematches and notextmatches for example.

#Comment by Raymond (talk | contribs)   16:45, 30 January 2009

Reverted with r46601

Status & tagging log