r45651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45650‎ | r45651 | r45652 >
Date:20:11, 10 January 2009
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
Wrap 'searchresulttext' into a div with class
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -945,17 +945,17 @@
946946 'search' => $textMatches->getSuggestionQuery(),
947947 'fulltext' => wfMsg('search')),
948948 $this->powerSearchOptions());
949 -
 949+
950950 $suggestLink = $sk->makeKnownLinkObj( $st,
951951 $textMatches->getSuggestionSnippet(),
952952 $stParams );
953 -
 953+
954954 $wgOut->addHTML('<div class="searchdidyoumean">'.wfMsg('search-suggest',$suggestLink).'</div>');
955955 }
956956
957957 $wgOut->addHTML( $extra );
958958
959 - $wgOut->addWikiMsg( 'searchresulttext' );
 959+ $wgOut->wrapWikiMsg( '<div class="mw-searchresult">$1</div>', 'searchresulttext' );
960960
961961 if( '' === trim( $term ) ) {
962962 // Empty query -- straight view of search form

Follow-up revisions

RevisionCommit summaryAuthorDate
r46419Revert r45651 "Wrap 'searchresulttext' into a div with class"...brion04:12, 28 January 2009
r46720Wrap 'searchresulttext' into a div with class...raymond17:52, 2 February 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   04:09, 28 January 2009

This causes breakage when the message text starts with line-start-markup such as a table or list.

#Comment by Brion VIBBER (talk | contribs)   04:21, 28 January 2009

Example on Commons:

Whee

Reverted in r46419

Status & tagging log