r46474 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r46473‎ | r46474 | r46475 >
Date:19:57, 28 January 2009
Author:brion
Status:ok (Comments)
Tags:
Comment:
Tweak for bug 3043 -- disable feed link icons in RTL since they display incorrectly in IE and some other browsers (same as external link icons).
I thought this had been done previously, since they didn't show up when I did a quick test in RTL, but I guess I was wrong. :P
Modified paths:
  • /trunk/phase3/skins/common/common_rtl.css (modified) (history)
  • /trunk/phase3/skins/modern/rtl.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)
  • /trunk/phase3/skins/simple/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/rtl.css
——@@ -148,7 +148,7 @@
149149 float: left;
150150 }
151151 /* Fix link icons */
152 -.external {
 152+.external, a.feedlink {
153153 padding: 0 !important;
154154 background: none !important;
155155 }
Index: trunk/phase3/skins/modern/rtl.css
——@@ -44,7 +44,7 @@
4545 }
4646
4747 /* Fix link icons */
48 -.external {
 48+.external, a.feedlink {
4949 padding: 0 !important;
5050 background: none !important;
5151 }
Index: trunk/phase3/skins/common/common_rtl.css
——@@ -48,7 +48,7 @@
4949 }
5050
5151 /* feed links */
52 -a.feedlink {
 52+a.feedlink, a.feedlink {
5353 background: none;
5454 padding-left: 0;
5555 }
Index: trunk/phase3/skins/simple/rtl.css
——@@ -100,7 +100,7 @@
101101 }
102102
103103 /* Fix link icons */
104 -.external {
 104+.external, a.feedlink {
105105 padding: 0 !important;
106106 background: none !important;
107107 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r46476bump style version for r46474brion19:58, 28 January 2009
r46488* tweak and fix r46474danny_b21:06, 28 January 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46058* (bug 3043) - RSS feed link should have silly orange icon...danny_b02:09, 23 January 2009
r46060* (bug 3043) - RSS feed link should have silly orange icon...danny_b03:39, 23 January 2009
r46061* re: r46058 & r46060 (bug 3043)danny_b03:51, 23 January 2009

Comments

#Comment by Danny B. (talk | contribs)   21:10, 28 January 2009

simple/rtl.css tweaked and common/common_rtl.css fixed in r46488

Status & tagging log