r46058 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46057‎ | r46058 | r46059 >
Date:02:09, 23 January 2009
Author:danny_b
Status:ok (Comments)
Tags:
Comment:
* (bug 3043) - RSS feed link should have silly orange icon
** Monobook & Modern skins implementation
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/common/images/feed-icon.png (added) (history)
  • /trunk/phase3/skins/modern/feed-icon.png (added) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/modern/rtl.css (modified) (history)
  • /trunk/phase3/skins/monobook/feed-icon.png (added) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -1455,7 +1455,7 @@
14561456 * to ensure that client-side caches don't keep obsolete copies of global
14571457 * styles.
14581458 */
1459 -$wgStyleVersion = '199';
 1459+$wgStyleVersion = '200';
14601460
14611461
14621462 # Server-side caching:
Index: trunk/phase3/skins/MonoBook.php
@@ -295,8 +295,8 @@
296296 <?php }
297297 if($this->data['feeds']) { ?>
298298 <li id="feedlinks"><?php foreach($this->data['feeds'] as $key => $feed) {
299 - ?><span id="<?php echo Sanitizer::escapeId( "feed-$key" ) ?>"><a href="<?php
300 - echo htmlspecialchars($feed['href']) ?>"<?php echo $this->skin->tooltipAndAccesskey('feed-'.$key) ?>><?php echo htmlspecialchars($feed['text'])?></a>&nbsp;</span>
 299+ ?><a id="<?php echo Sanitizer::escapeId( "feed-$key" ) ?>" href="<?php
 300+ echo htmlspecialchars($feed['href']) ?>"<?php echo $this->skin->tooltipAndAccesskey('feed-'.$key) ?>><?php echo htmlspecialchars($feed['text'])?></a>&nbsp;
301301 <?php } ?></li><?php
302302 }
303303
Index: trunk/phase3/skins/Modern.php
@@ -293,8 +293,8 @@
294294 <?php }
295295 if($this->data['feeds']) { ?>
296296 <li id="feedlinks"><?php foreach($this->data['feeds'] as $key => $feed) {
297 - ?><span id="<?php echo Sanitizer::escapeId( "feed-$key" ) ?>"><a href="<?php
298 - echo htmlspecialchars($feed['href']) ?>"<?php echo $this->skin->tooltipAndAccesskey('feed-'.$key) ?>><?php echo htmlspecialchars($feed['text'])?></a>&nbsp;</span>
 297+ ?><a id="<?php echo Sanitizer::escapeId( "feed-$key" ) ?>" href="<?php
 298+ echo htmlspecialchars($feed['href']) ?>"<?php echo $this->skin->tooltipAndAccesskey('feed-'.$key) ?>><?php echo htmlspecialchars($feed['text'])?></a>&nbsp;
299299 <?php } ?></li><?php
300300 }
301301
Index: trunk/phase3/skins/monobook/main.css
@@ -900,6 +900,12 @@
901901 z-index: 3;
902902 }
903903
 904+/* feed links */
 905+#feed-atom, #feed-rss {
 906+ background: url("feed-icon.png") center left no-repeat;
 907+ padding-left: 16px;
 908+}
 909+
904910 /* TODO: #t-iscite is only used by the Cite extension, come up with some
905911 * system which allows extensions to add to this file on the fly
906912 */
Index: trunk/phase3/skins/monobook/feed-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/skins/monobook/feed-icon.png
___________________________________________________________________
Added: svn:mime-type
907913 + application/octet-stream
Index: trunk/phase3/skins/monobook/rtl.css
@@ -77,6 +77,12 @@
7878 right: 0;
7979 }
8080
 81+/* feed links */
 82+#feed-atom, #feed-rss {
 83+ background: none;
 84+ padding-left: 0;
 85+}
 86+
8187 #p-cactions {
8288 left: auto;
8389 right: 11.5em;
Index: trunk/phase3/skins/modern/rtl.css
@@ -116,6 +116,12 @@
117117 padding: 0.1em 1em 0.3em 0;
118118 }
119119
 120+/* feed links */
 121+#feed-atom, #feed-rss {
 122+ background: none;
 123+ padding-left: 0;
 124+}
 125+
120126 #p-cactions li {
121127 float: right;
122128 }
Index: trunk/phase3/skins/modern/main.css
@@ -162,6 +162,12 @@
163163 margin-top: .4em;
164164 }
165165
 166+/* feed links */
 167+#feed-atom, #feed-rss {
 168+ background: url("feed-icon.png") center left no-repeat;
 169+ padding-left: 16px;
 170+}
 171+
166172 .portlet h5 {
167173 padding: 0.1em 0 0.3em 1em;
168174 margin: 0 0 0 0;
Index: trunk/phase3/skins/modern/feed-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/skins/modern/feed-icon.png
___________________________________________________________________
Added: svn:mime-type
169175 + application/octet-stream
Index: trunk/phase3/skins/common/images/feed-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/skins/common/images/feed-icon.png
___________________________________________________________________
Added: svn:mime-type
170176 + application/octet-stream

Follow-up revisions

RevisionCommit summaryAuthorDate
r46060* (bug 3043) - RSS feed link should have silly orange icon...danny_b03:39, 23 January 2009
r46061* re: r46058 & r46060 (bug 3043)danny_b03:51, 23 January 2009
r46474Tweak for bug 3043 -- disable feed link icons in RTL since they display incor...brion19:57, 28 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   02:31, 23 January 2009

Lookin' good :D

#Comment by Danny B. (talk | contribs)   03:40, 23 January 2009

Improved in r46060 to work in every skin.

Status & tagging log