r45948 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45947‎ | r45948 | r45949 >
Date:03:50, 21 January 2009
Author:mrzman
Status:ok (Comments)
Tags:
Comment:
Fix for r45862, handle indefinite blocks correctly (and use a less anglo-centric timestamp format)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -113,7 +113,11 @@
114114 $this->BlockEmail = $currentBlock->mBlockEmail;
115115 $this->BlockHideName = $currentBlock->mHideName;
116116 $this->BlockAllowUsertalk = $currentBlock->mAllowUsertalk;
117 - $this->BlockOther = wfTimestamp( TS_RFC2822, $currentBlock->mExpiry );
 117+ if( $currentBlock->mExpiry == 'infinity' ) {
 118+ $this->BlockOther = 'indefinite';
 119+ } else {
 120+ $this->BlockOther = wfTimestamp( TS_ISO_8601, $currentBlock->mExpiry );
 121+ }
118122 $this->BlockReason = $currentBlock->mReason;
119123 }
120124 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45862(bug 17045) Prefill the block form with the options of the existing block whe...mrzman02:57, 18 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   04:29, 21 January 2009

woohoo :D

Status & tagging log