r45947 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45946‎ | r45947 | r45948 >
Date:01:25, 21 January 2009
Author:aaron
Status:ok (Comments)
Tags:todo 
Comment:
(bug 16025) 'Call to undefined method SimpleCaptcha::showImage()'
Modified paths:
  • /trunk/extensions/ConfirmEdit/ConfirmEdit_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmEdit/ConfirmEdit_body.php
——@@ -54,7 +54,8 @@
5555 $instance = ConfirmEditHooks::getInstance();
5656 switch( $par ) {
5757 case "image":
58 - return $instance->showImage();
 58+ if( method_exists($instance,'showImage') )
 59+ return $instance->showImage();
5960 case "help":
6061 default:
6162 return $instance->showHelp();

Comments

#Comment by Brion VIBBER (talk | contribs)   04:27, 21 January 2009

If it doesn't exist, this'll fall through to the help page display, which doesn't seem quite right.

#Comment by Aaron Schulz (talk | contribs)   04:49, 21 January 2009

Maybe a special message is in order; I justed wanted to get rid of the fatal

#Comment by Aaron Schulz (talk | contribs)   01:25, 25 January 2009

Changing to TODO

Status & tagging log