r45788 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45787‎ | r45788 | r45789 >
Date:22:08, 15 January 2009
Author:tango
Status:reverted (Comments)
Tags:
Comment:
Page moves should not be minor edits
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -2664,7 +2664,7 @@
26652665 }
26662666
26672667 # Save a null revision in the page's history notifying of the move
2668 - $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, true );
 2668+ $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, false );
26692669 $nullRevId = $nullRevision->insertOn( $dbw );
26702670
26712671 $article = new Article( $this );
@@ -2763,7 +2763,7 @@
27642764 $now = $dbw->timestamp();
27652765
27662766 # Save a null revision in the page's history notifying of the move
2767 - $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, true );
 2767+ $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, false );
27682768 $nullRevId = $nullRevision->insertOn( $dbw );
27692769
27702770 $article = new Article( $this );
Index: trunk/phase3/RELEASE-NOTES
@@ -42,6 +42,7 @@
4343 * (bug 16852) padleft and padright now handle multibyte characters correctly
4444 * (bug 17010) maintenance/namespaceDupes.php now add the suffix recursively if
4545 the destination page exists
 46+* Page moves should not be minor edits
4647
4748 == API changes in 1.15 ==
4849 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Follow-up revisions

RevisionCommit summaryAuthorDate
r45938Revert r45788 "Page moves should not be minor edits"...brion22:32, 20 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:32, 20 January 2009

Reverted in r45938 -- maybe discuss the change first?

Status & tagging log