r45938 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45937‎ | r45938 | r45939 >
Date:22:32, 20 January 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r45788 "Page moves should not be minor edits"
Would prefer to see some discussion first; it's not obvious whether the change is needed/wanted.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -2664,7 +2664,7 @@
26652665 }
26662666
26672667 # Save a null revision in the page's history notifying of the move
2668 - $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, false );
 2668+ $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, true );
26692669 $nullRevId = $nullRevision->insertOn( $dbw );
26702670
26712671 $article = new Article( $this );
@@ -2763,7 +2763,7 @@
27642764 $now = $dbw->timestamp();
27652765
27662766 # Save a null revision in the page's history notifying of the move
2767 - $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, false );
 2767+ $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, true );
27682768 $nullRevId = $nullRevision->insertOn( $dbw );
27692769
27702770 $article = new Article( $this );
Index: trunk/phase3/RELEASE-NOTES
@@ -53,7 +53,6 @@
5454 * (bug 16852) padleft and padright now handle multibyte characters correctly
5555 * (bug 17010) maintenance/namespaceDupes.php now add the suffix recursively if
5656 the destination page exists
57 -* Page moves should not be minor edits
5857 * (bug 17035) Special:Upload now fails gracefully if PHP's file_uploads has been
5958 disabled
6059 * Fixing the caching issue by using -{T|xxx}- syntax (only applies on wiki with LanguageConverter class)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45788Page moves should not be minor editstango22:08, 15 January 2009

Status & tagging log