r45748 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45747‎ | r45748 | r45749 >
Date:20:38, 14 January 2009
Author:ialex
Status:deferred
Tags:
Comment:
* htmlspecialchars() page title so that Firefox doesn't throw an error when the has a "&" in its title
* use SpecialPage::getTitleFor() to get the url
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_ParserExtensions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_ParserExtensions.php
@@ -71,10 +71,9 @@
7272
7373 // add link to RDF to HTML header
7474 SMWOutputs::requireHeadItem('smw_rdf', '<link rel="alternate" type="application/rdf+xml" title="' .
75 - $parser->getTitle()->getPrefixedText() . '" href="' .
76 - htmlspecialchars($parser->getOptions()->getSkin()->makeSpecialUrl(
77 - 'ExportRDF/' . $parser->getTitle()->getPrefixedText(), 'xmlmime=rdf'
78 - )) . "\" />");
 75+ htmlspecialchars( $parser->getTitle()->getPrefixedText() ) . '" href="' .
 76+ htmlspecialchars(
 77+ SpecialPage::getTitleFor( 'ExportRDF', $parser->getTitle()->getPrefixedText() )->getLocalUrl( 'xmlmime=rdf' ) ) . "\" />");
7978
8079 SMWOutputs::commitToParser($parser);
8180 return true; // always return true, in order not to stop MW's hook processing!

Follow-up revisions

RevisionCommit summaryAuthorDate
r45752Backport r45748. Also put backported API changes below the other API changes ...catrope21:36, 14 January 2009

Status & tagging log