r45752 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45751‎ | r45752 | r45753 >
Date:21:36, 14 January 2009
Author:catrope
Status:deferred
Tags:
Comment:
Backport r45748. Also put backported API changes below the other API changes rather than in a separate section.
Modified paths:
  • /branches/REL1_14/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_14/phase3/includes/api/ApiMain.php (modified) (history)
  • /branches/REL1_14/phase3/includes/api/ApiResult.php (modified) (history)

Diff [purge]

Index: branches/REL1_14/phase3/includes/api/ApiResult.php
@@ -186,6 +186,15 @@
187187 ApiResult :: setElement($data, $name, $value); // Add named element
188188 }
189189
 190+ /**
 191+ * Ensure all values in this result are valid UTF-8.
 192+ */
 193+ public function cleanUpUTF8()
 194+ {
 195+ $data = & $this->getData();
 196+ array_walk_recursive($data, array('UtfNormal', 'cleanUp'));
 197+ }
 198+
190199 public function execute() {
191200 ApiBase :: dieDebug(__METHOD__, 'execute() is not supported on Result object');
192201 }
Index: branches/REL1_14/phase3/includes/api/ApiMain.php
@@ -438,6 +438,7 @@
439439 * Print results using the current printer
440440 */
441441 protected function printResult($isError) {
 442+ $this->getResult()->cleanupUTF8();
442443 $printer = $this->mPrinter;
443444 $printer->profileIn();
444445
Index: branches/REL1_14/phase3/RELEASE-NOTES
@@ -18,11 +18,6 @@
1919 Those wishing to use the latest code instead of a branch release can obtain
2020 it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
2121
22 -=== API changes in 1.14rc1 ===
23 -* (bug 16798) JSON encoding errors for some characters outside the BMP
24 -* (bug 16629) prop=info&inprop=protection lists empty legacy protections
25 - incorrectly
26 -
2722 === Configuration changes in 1.14 ===
2823
2924 * $wgExemptFromUserRobotsControl is an array of namespaces to be exempt from
@@ -584,6 +579,10 @@
585580 * (bug 16726) siprop=namespacealiases should also list localized aliases
586581 * (bug 16730) Added apprfiltercascade parameter to list=allpages to filter
587582 cascade-protected pages
 583+* (bug 16798) JSON encoding errors for some characters outside the BMP
 584+* (bug 16629) prop=info&inprop=protection lists empty legacy protections
 585+ incorrectly
 586+* (bug 15261, 16262) API no longer outputs invalid UTF-8
588587
589588 === Languages updated in 1.14 ===
590589

Follow-up revisions

RevisionCommit summaryAuthorDate
r45753Remove RELEASE-NOTES entries for backported changes (backported in r45682, r4...catrope21:39, 14 January 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45748* htmlspecialchars() page title so that Firefox doesn't throw an error when t...ialex20:38, 14 January 2009

Status & tagging log