r45730 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45729‎ | r45730 | r45731 >
Date:16:26, 14 January 2009
Author:ashley
Status:deferred (Comments)
Tags:
Comment:
nasty css fix
Modified paths:
  • /trunk/extensions/SocialProfile/UserProfile/SpecialUploadAvatar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserProfile/SpecialUploadAvatar.php
@@ -49,6 +49,8 @@
5050 $wgOut->setHTMLTitle( wfMsg( 'pagetitle', wfMsg('user-profile-picture-title') ) );
5151
5252 $wgOut->addStyle( '../..' . $wgUserProfileScripts . '/UserProfile.css' );
 53+ // Nasty hack since UserProfile.css is loaded before skin's main.css
 54+ $wgOut->addHTML( '<style>.profile-tab a:visited { color: #FFFFFF; } .profile-tab-on a:visited { color: #FFFFFF; }</style>' );
5355 $this->initAvatar($wgRequest);
5456 $this->executeAvatar();
5557 }

Comments

#Comment by Simetrical (talk | contribs)   17:26, 14 January 2009

Can't you use !important for this, if the cascade order is a problem, or a higher-specificity selector? Or, better. load UserProfile.css after main.css . . .

#Comment by Sayuri (talk | contribs)   13:17, 15 January 2009

Thank you for the suggestion, fixed in r45767. :-)

Status & tagging log