r45767 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45766‎ | r45767 | r45768 >
Date:13:16, 15 January 2009
Author:ashley
Status:deferred
Tags:
Comment:
better css fix, per Simetrical's suggestion on http://www.mediawiki.org/wiki/Special:Code/MediaWiki/45730#c1262
Modified paths:
  • /trunk/extensions/SocialProfile/UserProfile/SpecialUpdateProfile.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/SpecialUploadAvatar.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfile.css (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserProfile/UserProfile.css
@@ -567,6 +567,14 @@
568568 color:#466C2C;
569569 }
570570
 571+.profile-tab a:visited {
 572+ color: #FFFFFF !important;
 573+}
 574+
 575+.profile-tab-on a:visited {
 576+ color: #FFFFFF !important;
 577+}
 578+
571579 .profile-update-button {
572580 background-color:#78BA5D;
573581 border:1px solid #6B6B6B;
Index: trunk/extensions/SocialProfile/UserProfile/SpecialUpdateProfile.php
@@ -66,8 +66,6 @@
6767 // Add CSS & JS
6868 $wgOut->addStyle( '../..' . $wgUserProfileScripts . '/UserProfile.css' );
6969 $wgOut->addScriptFile( $wgUserProfileScripts.'/UpdateProfile.js' );
70 - // Nasty hack since UserProfile.css is loaded before skin's main.css
71 - $wgOut->addHTML( '<style>.profile-tab a:visited { color: #FFFFFF; } .profile-tab-on a:visited { color: #FFFFFF; }</style>' );
7270
7371 if( $wgRequest->wasPosted() ){
7472 //$section = $wgRequest->getVal('section');
Index: trunk/extensions/SocialProfile/UserProfile/SpecialUploadAvatar.php
@@ -49,8 +49,6 @@
5050 $wgOut->setHTMLTitle( wfMsg( 'pagetitle', wfMsg('user-profile-picture-title') ) );
5151
5252 $wgOut->addStyle( '../..' . $wgUserProfileScripts . '/UserProfile.css' );
53 - // Nasty hack since UserProfile.css is loaded before skin's main.css
54 - $wgOut->addHTML( '<style>.profile-tab a:visited { color: #FFFFFF; } .profile-tab-on a:visited { color: #FFFFFF; }</style>' );
5553 $this->initAvatar($wgRequest);
5654 $this->executeAvatar();
5755 }

Status & tagging log