r45517 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45516‎ | r45517 | r45518 >
Date:20:34, 7 January 2009
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
* (bug 16921) Add a maxlength for the reason field of the page move form
Changed from 'textarea' to 'text' because 'textarea' does not support maxlength.
Makes it consistent with all other reason fields.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -184,7 +184,7 @@
185185 Xml::label( wfMsg( 'newtitle' ), 'wpNewTitle' ) .
186186 "</td>
187187 <td class='mw-input'>" .
188 - Xml::input( 'wpNewTitle', 40, $newTitle->getPrefixedText(), array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) .
 188+ Xml::input( 'wpNewTitle', 60, $newTitle->getPrefixedText(), array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) .
189189 Xml::hidden( 'wpOldTitle', $this->oldTitle->getPrefixedText() ) .
190190 "</td>
191191 </tr>
@@ -193,7 +193,8 @@
194194 Xml::label( wfMsg( 'movereason' ), 'wpReason' ) .
195195 "</td>
196196 <td class='mw-input'>" .
197 - Xml::tags( 'textarea', array( 'name' => 'wpReason', 'id' => 'wpReason', 'cols' => 60, 'rows' => 2 ), htmlspecialchars( $this->reason ) ) .
 197+ Xml::input( 'wpReason', 60, $this->reason, array( 'type' => 'text',
 198+ 'id' => 'wpReason', 'maxlength' => 200 ) ) .
198199 "</td>
199200 </tr>"
200201 );
Index: trunk/phase3/RELEASE-NOTES
@@ -474,6 +474,7 @@
475475 that STDIN can be used for page list
476476 * (bug 16560) Special:Random returns a page from ContentNamespaces, and no
477477 longer from NS_MAIN
 478+* (bug 16921) Add a maxlength for the reason field of the page move form
478479
479480 === API changes in 1.14 ===
480481

Follow-up revisions

RevisionCommit summaryAuthorDate
r45571Reverted r45517 " * (bug 16921) Add a maxlength for the reason field of the p...brion18:51, 8 January 2009
r60054maxlength=200 for page move summary in HTML5...simetrical00:11, 15 December 2009
r86846(bug 16921) Add JavaScript-based enforcing of byte limits on move and protect...catrope11:39, 25 April 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:51, 8 January 2009

Reverted in r45571 -- this field is deliberately larger to make it visually distinct from the target title field.

Status & tagging log