r45571 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45570‎ | r45571 | r45572 >
Date:18:51, 8 January 2009
Author:brion
Status:ok
Tags:
Comment:
Reverted r45517 " * (bug 16921) Add a maxlength for the reason field of the page move form. Changed from 'textarea' to 'text' because 'textarea' does not support maxlength. Makes it consistent with all other reason fields."
This field is deliberately not a single-line text input field because it caused confusion when it was.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -184,7 +184,7 @@
185185 Xml::label( wfMsg( 'newtitle' ), 'wpNewTitle' ) .
186186 "</td>
187187 <td class='mw-input'>" .
188 - Xml::input( 'wpNewTitle', 60, $newTitle->getPrefixedText(), array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) .
 188+ Xml::input( 'wpNewTitle', 40, $newTitle->getPrefixedText(), array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) .
189189 Xml::hidden( 'wpOldTitle', $this->oldTitle->getPrefixedText() ) .
190190 "</td>
191191 </tr>
@@ -193,8 +193,7 @@
194194 Xml::label( wfMsg( 'movereason' ), 'wpReason' ) .
195195 "</td>
196196 <td class='mw-input'>" .
197 - Xml::input( 'wpReason', 60, $this->reason, array( 'type' => 'text',
198 - 'id' => 'wpReason', 'maxlength' => 200 ) ) .
 197+ Xml::tags( 'textarea', array( 'name' => 'wpReason', 'id' => 'wpReason', 'cols' => 60, 'rows' => 2 ), htmlspecialchars( $this->reason ) ) .
199198 "</td>
200199 </tr>"
201200 );
Index: trunk/phase3/RELEASE-NOTES
@@ -32,7 +32,6 @@
3333
3434 === Bug fixes in 1.15 ===
3535
36 -* (bug 16921) Add a maxlength for the reason field of the page move form
3736
3837 === Languages updated in 1.15 ===
3938

Follow-up revisions

RevisionCommit summaryAuthorDate
r60054maxlength=200 for page move summary in HTML5...simetrical00:11, 15 December 2009
r86846(bug 16921) Add JavaScript-based enforcing of byte limits on move and protect...catrope11:39, 25 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45517* (bug 16921) Add a maxlength for the reason field of the page move form...raymond20:34, 7 January 2009

Status & tagging log