r45376 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45375‎ | r45376 | r45377 >
Date:16:59, 3 January 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
(bug 15427) Make monobook firstheading have an ID (instead of class) like modern
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/chick/IE50Fixes.css (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE50Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/IE50Fixes.css
@@ -63,5 +63,5 @@
6464 padding:0;
6565 margin:0;
6666 }
67 -.firstHeading { margin-bottom: 0.3em; }
 67+#firstHeading { margin-bottom: 0.3em; }
6868 /*div{ border:1px solid Red !important;}*/
Index: trunk/phase3/skins/chick/main.css
@@ -176,7 +176,7 @@
177177 #bodyContent h5 {
178178 margin-bottom: 0.3em;
179179 }
180 -.firstHeading { margin-bottom:0.1em; }
 180+#firstHeading { margin-bottom:0.1em; }
181181
182182 /* user notification thing */
183183 .usermessage {
Index: trunk/phase3/skins/monobook/IE50Fixes.css
@@ -63,5 +63,5 @@
6464 padding:0;
6565 margin: 0;
6666 }
67 -.firstHeading { margin-bottom: .3em; }
 67+#firstHeading { margin-bottom: .3em; }
6868 /*div{ border:1px solid Red !important;}*/
Index: trunk/phase3/skins/monobook/main.css
@@ -260,7 +260,7 @@
261261 #bodyContent h3, #bodyContent h4, #bodyContent h5 {
262262 margin-bottom: .3em;
263263 }
264 -.firstHeading {
 264+#firstHeading {
265265 margin-bottom: .1em;
266266 /* These two rules hack around bug 2013 (fix for more limited bug 11325).
267267 When bug 2013 is fixed properly, they should be removed. */
Index: trunk/phase3/skins/MonoBook.php
@@ -115,7 +115,7 @@
116116 <div id="content">
117117 <a name="top" id="top"></a>
118118 <?php if($this->data['sitenotice']) { ?><div id="siteNotice"><?php $this->html('sitenotice') ?></div><?php } ?>
119 - <h1 class="firstHeading"><?php $this->data['displaytitle']!=""?$this->html('title'):$this->text('title') ?></h1>
 119+ <h1 id="firstHeading"><?php $this->data['displaytitle']!=""?$this->html('title'):$this->text('title') ?></h1>
120120 <div id="bodyContent">
121121 <h3 id="siteSub"><?php $this->msg('tagline') ?></h3>
122122 <div id="contentSub"><?php $this->html('subtitle') ?></div>

Follow-up revisions

RevisionCommit summaryAuthorDate
r45377Followup to r45376 (changing class="firstHeading" to an id). We still want th...demon17:57, 3 January 2009

Comments

#Comment by Raymond (talk | contribs)   17:35, 3 January 2009
#Comment by Aaron Schulz (talk | contribs)   17:37, 3 January 2009

just add the class back then :)

#Comment by 😂 (talk | contribs)   17:59, 3 January 2009

Done in r45377.

Status & tagging log