r45377 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45376‎ | r45377 | r45378 >
Date:17:57, 3 January 2009
Author:demon
Status:ok
Tags:
Comment:
Followup to r45376 (changing class="firstHeading" to an id). We still want the class there too (as pointed out by Raymond) as it will break a lot of custom user styles. Also, bump $wgStyleVersion.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -115,7 +115,7 @@
116116 <div id="content">
117117 <a name="top" id="top"></a>
118118 <?php if($this->data['sitenotice']) { ?><div id="siteNotice"><?php $this->html('sitenotice') ?></div><?php } ?>
119 - <h1 id="firstHeading"><?php $this->data['displaytitle']!=""?$this->html('title'):$this->text('title') ?></h1>
 119+ <h1 id="firstHeading" class="firstHeading"><?php $this->data['displaytitle']!=""?$this->html('title'):$this->text('title') ?></h1>
120120 <div id="bodyContent">
121121 <h3 id="siteSub"><?php $this->msg('tagline') ?></h3>
122122 <div id="contentSub"><?php $this->html('subtitle') ?></div>
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1446,7 +1446,7 @@
14471447 * to ensure that client-side caches don't keep obsolete copies of global
14481448 * styles.
14491449 */
1450 -$wgStyleVersion = '194';
 1450+$wgStyleVersion = '195';
14511451
14521452
14531453 # Server-side caching:

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45376(bug 15427) Make monobook firstheading have an ID (instead of class) like modernaaron16:59, 3 January 2009

Status & tagging log