r45363 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45362‎ | r45363 | r45364 >
Date:06:25, 3 January 2009
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
(bug 15320) Show login page if not logged in (for watchlist)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWatchlist.php
@@ -20,10 +20,14 @@
2121
2222 # Anons don't get a watchlist
2323 if( $wgUser->isAnon() ) {
24 - $wgOut->setPageTitle( wfMsg( 'watchnologin' ) );
2524 $llink = $skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Userlogin' ),
2625 wfMsgHtml( 'loginreqlink' ), 'returnto=' . $specialTitle->getPrefixedUrl() );
2726 $wgOut->addHTML( wfMsgWikiHtml( 'watchlistanontext', $llink ) );
 27+ # Add login form for convenience
 28+ $form = new LoginForm( $wgRequest );
 29+ $form->execute();
 30+ # Set page title (also LoginForm sets it too, but we prefer this one)
 31+ $wgOut->setPageTitle( wfMsg( 'watchnologin' ) );
2832 return;
2933 }
3034

Follow-up revisions

RevisionCommit summaryAuthorDate
r45476Reverting r45363 "(bug 15320) Show login page if not logged in (for watchlist)"...brion01:49, 7 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   01:50, 7 January 2009

1) Behavior should be consistent; we don't do this anywhere else.

2) We want to be able to consolidate the login form to a secure location, which this would prevent.

Reverting in r45476 and resolving WONTFIX.

Status & tagging log