r45476 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45475‎ | r45476 | r45477 >
Date:01:49, 7 January 2009
Author:brion
Status:ok
Tags:
Comment:
Reverting r45363 "(bug 15320) Show login page if not logged in (for watchlist)"

1) Behavior should be consistent; we don't do this anywhere else.

2) We want to be able to consolidate the login form to a secure location, which this would prevent.

Reverting and resolving WONTFIX.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWatchlist.php
@@ -20,14 +20,10 @@
2121
2222 # Anons don't get a watchlist
2323 if( $wgUser->isAnon() ) {
 24+ $wgOut->setPageTitle( wfMsg( 'watchnologin' ) );
2425 $llink = $skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Userlogin' ),
2526 wfMsgHtml( 'loginreqlink' ), 'returnto=' . $specialTitle->getPrefixedUrl() );
2627 $wgOut->addHTML( wfMsgWikiHtml( 'watchlistanontext', $llink ) );
27 - # Add login form for convenience
28 - $form = new LoginForm( $wgRequest );
29 - $form->execute();
30 - # Set page title (also LoginForm sets it too, but we prefer this one)
31 - $wgOut->setPageTitle( wfMsg( 'watchnologin' ) );
3228 return;
3329 }
3430

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45363(bug 15320) Show login page if not logged in (for watchlist)aaron06:25, 3 January 2009

Status & tagging log