r45343 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45342‎ | r45343 | r45344 >
Date:20:50, 2 January 2009
Author:aaron
Status:reverted (Comments)
Tags:todo 
Comment:
(bug 16659) Prettify permalinks. Just use ?oldid=x
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
——@@ -879,9 +879,10 @@
880880
881881 // Also add a "permalink" while we're at it
882882 if ( $this->mRevisionId ) {
 883+ global $wgScript;
883884 $nav_urls['permalink'] = array(
884885 'text' => wfMsg( 'permalink' ),
885 - 'href' => $wgTitle->getLocalURL( "oldid=$this->mRevisionId" )
 886+ 'href' => "{$wgScript}?oldid={$this->mRevisionId}"
886887 );
887888 }
888889

Follow-up revisions

RevisionCommit summaryAuthorDate
r46290Revert r45343 "(bug 16659) Prettify permalinks. Just use ?oldid=x" for now....brion21:53, 26 January 2009
r46291revert r45343 on branch as wellbrion21:56, 26 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   00:06, 7 January 2009

Would be nice to be able to use $wgActionPaths for this sort of thing though, make a prettier permalink structure where possible to set up cleanly. Tagging todo with a note :)

#Comment by Brion VIBBER (talk | contribs)   21:56, 26 January 2009

This hasn't been very popular so far, and is still incomplete. Pulling back for now in r46290 on trunk, r46291 on 1.14 branch.

Status & tagging log