r46290 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r46289‎ | r46290 | r46291 >
Date:21:53, 26 January 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r45343 "(bug 16659) Prettify permalinks. Just use ?oldid=x" for now.
This hasn't been very popular so far; pulling it back pending further discussion (as on bug)
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
——@@ -880,10 +880,9 @@
881881
882882 // Also add a "permalink" while we're at it
883883 if ( $this->mRevisionId ) {
884 - global $wgScript;
885884 $nav_urls['permalink'] = array(
886885 'text' => wfMsg( 'permalink' ),
887 - 'href' => "{$wgScript}?oldid={$this->mRevisionId}"
 886+ 'href' => $wgTitle->getLocalURL( "oldid=$this->mRevisionId" )
888887 );
889888 }
890889

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45343(bug 16659) Prettify permalinks. Just use ?oldid=xaaron20:50, 2 January 2009

Status & tagging log