r45246 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45245‎ | r45246 | r45247 >
Date:19:16, 31 December 2008
Author:brion
Status:ok
Tags:
Comment:
Revert r45106 "(bug 16617) Add "talk" link to list of templates in edit mode"

Clutters the interface unnecessarily, and uses link texts which don't even match in formatting, making it very unattractive.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1630,13 +1630,11 @@
16311631 $protected = '';
16321632 }
16331633 if( $titleObj->quickUserCan( 'edit' ) ) {
1634 - $editLink = $this->link( $titleObj, wfMsgHtml( 'editlink' ), array(), array( 'action' => 'edit' ), 'known' );
 1634+ $editLink = $this->makeLinkObj( $titleObj, wfMsg('editlink'), 'action=edit' );
16351635 } else {
1636 - $editLink = $this->link( $titleObj, wfMsgHtml( 'viewsourcelink' ), array(), array( 'action' => 'edit' ), 'known' );
 1636+ $editLink = $this->makeLinkObj( $titleObj, wfMsg('viewsourcelink'), 'action=edit' );
16371637 }
1638 - $talkLink = $this->link( $titleObj->getTalkPage(), wfMsgHtml( 'talkpagelinktext' ) );
1639 - $outText .= Xml::tags( 'li', array(),
1640 - $this->link( $titleObj ) . ' (' . $editLink . ' ' . wfMsgHtml( 'pipe-separator' ) . ' ' . $talkLink . ') ' . $protected ) . "\n";
 1638+ $outText .= '<li>' . $this->link( $titleObj ) . ' (' . $editLink . ') ' . $protected . '</li>';
16411639 }
16421640 $outText .= '</ul>';
16431641 }
Index: trunk/phase3/RELEASE-NOTES
@@ -252,7 +252,6 @@
253253 'li' elements
254254 * (bug 16754) Making arbitrary rows of sortable tables sticky:
255255 |- class="unsortable"
256 -* (bug 16617) Add "talk" link to list of templates in edit mode
257256 * Show subversion too even if a "normal" version number is available
258257 * (bug 16121) Add a note that a page move was without creating a redirect in the
259258 move log

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45106* (bug 16617) Add "talk" link to list of templates in edit mode...raymond21:15, 27 December 2008

Status & tagging log