r45106 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45105‎ | r45106 | r45107 >
Date:21:15, 27 December 2008
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
* (bug 16617) Add "talk" link to list of templates in edit mode
Based on a patch by Nakon
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -1633,11 +1633,13 @@
16341634 $protected = '';
16351635 }
16361636 if( $titleObj->quickUserCan( 'edit' ) ) {
1637 - $editLink = $sk->makeLinkObj( $titleObj, wfMsg('editlink'), 'action=edit' );
 1637+ $editLink = $sk->link( $titleObj, wfMsg( 'editlink' ), array(), array( 'action' => 'edit' ), 'known' );
16381638 } else {
1639 - $editLink = $sk->makeLinkObj( $titleObj, wfMsg('viewsourcelink'), 'action=edit' );
 1639+ $editLink = $sk->link( $titleObj, wfMsg( 'viewsourcelink' ), array(), array( 'action' => 'edit' ), 'known' );
16401640 }
1641 - $outText .= '<li>' . $sk->link( $titleObj ) . ' (' . $editLink . ') ' . $protected . '</li>';
 1641+ $talkLink = $sk->link( $titleObj->getTalkPage(), wfMsg( 'talkpagelinktext' ) );
 1642+ $outText .= Xml::tags( 'li', array(),
 1643+ $sk->link( $titleObj ) . ' (' . $editLink . ' ' . wfMsg( 'pipe-separator' ) . ' ' . $talkLink . ') ' . $protected );
16421644 }
16431645 $outText .= '</ul>';
16441646 }
Index: trunk/phase3/RELEASE-NOTES
——@@ -252,6 +252,7 @@
253253 'li' elements
254254 * (bug 16754) Making arbitrary rows of sortable tables sticky:
255255 |- class="unsortable"
 256+* (bug 16617) Add "talk" link to list of templates in edit mode
256257
257258 === Bug fixes in 1.14 ===
258259

Follow-up revisions

RevisionCommit summaryAuthorDate
r45246Revert r45106 "(bug 16617) Add "talk" link to list of templates in edit mode"...brion19:16, 31 December 2008

Comments

#Comment by Nikerabbit (talk | contribs)   22:53, 27 December 2008

Mmm more and more links. I hope the usability project finds some solution for this.

#Comment by Voice of All (talk | contribs)   11:25, 28 December 2008

I'd like to see a show/hide think for all this template stuff.

#Comment by Brion VIBBER (talk | contribs)   19:16, 31 December 2008

Reverted in r45246

Clutters the interface unnecessarily, and uses link texts which don't even match in formatting, making it very unattractive.

Status & tagging log