r45247 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45246‎ | r45247 | r45248 >
Date:19:30, 31 December 2008
Author:ashley
Status:ok
Tags:
Comment:
check that $wgArticle is an instance of the Article class in Skin::pageStats() per Brion's commit summary on r45204
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1261,6 +1261,7 @@
12621262 $oldid = $wgRequest->getVal( 'oldid' );
12631263 $diff = $wgRequest->getVal( 'diff' );
12641264 if ( ! $wgOut->isArticle() ) { return ''; }
 1265+ if( !$wgArticle instanceOf Article ) { return ''; }
12651266 if ( isset( $oldid ) || isset( $diff ) ) { return ''; }
12661267 if ( 0 == $wgArticle->getID() ) { return ''; }
12671268

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45204Revert r45038 "only call pageStats function in Skin::printFooter if $wgArticl...brion21:34, 30 December 2008

Status & tagging log