r45213 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45212‎ | r45213 | r45214 >
Date:02:53, 31 December 2008
Author:rainman
Status:reverted (Comments)
Tags:
Comment:
(bug 5552) add a fulltext-only search mode to inputbox
Modified paths:
  • /trunk/extensions/InputBox/InputBox.classes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/InputBox/InputBox.classes.php
@@ -28,6 +28,7 @@
2929 private $mNamespaces = '';
3030 private $mID = '';
3131 private $mInline = false;
 32+ private $mHideGo = false;
3233
3334 /* Functions */
3435
@@ -141,7 +142,7 @@
142143
143144 // Line break
144145 $htmlOut .= $this->mBR;
145 - } else {
 146+ } else if( !$this->mHideGo ) {
146147 // Go button
147148 $htmlOut .= Xml::element( 'input',
148149 array(
@@ -448,6 +449,7 @@
449450 'hidden' => 'mHidden',
450451 'id' => 'mID',
451452 'inline' => 'mInline',
 453+ 'hidego' => 'mHideGo',
452454 );
453455 foreach ( $options as $name => $var ) {
454456 if ( isset( $values[$name] ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r45261Revert r45213 "(bug 5552) add a fulltext-only search mode to inputbox"...brion22:18, 31 December 2008
r45269(bug 5552) add a fulltext-only search mode to inputbox...rainman00:55, 1 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:18, 31 December 2008

"hidego" sounds kind of icky to me; perhaps type="fulltext" would be better?

Reverted for now in r45261

Status & tagging log