r45261 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45260‎ | r45261 | r45262 >
Date:22:18, 31 December 2008
Author:brion
Status:ok
Tags:
Comment:
Revert r45213 "(bug 5552) add a fulltext-only search mode to inputbox"
"hidego" sounds kind of icky to me; perhaps type="fulltext" would be better?
Modified paths:
  • /trunk/extensions/InputBox/InputBox.classes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/InputBox/InputBox.classes.php
@@ -28,7 +28,6 @@
2929 private $mNamespaces = '';
3030 private $mID = '';
3131 private $mInline = false;
32 - private $mHideGo = false;
3332 private $mPrefix = '';
3433
3534 /* Functions */
@@ -154,7 +153,7 @@
155154
156155 // Line break
157156 $htmlOut .= $this->mBR;
158 - } else if( !$this->mHideGo ) {
 157+ } else {
159158 // Go button
160159 $htmlOut .= Xml::element( 'input',
161160 array(
@@ -461,7 +460,6 @@
462461 'hidden' => 'mHidden',
463462 'id' => 'mID',
464463 'inline' => 'mInline',
465 - 'hidego' => 'mHideGo',
466464 'prefix' => 'mPrefix',
467465 );
468466 foreach ( $options as $name => $var ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r45269(bug 5552) add a fulltext-only search mode to inputbox...rainman00:55, 1 January 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45213(bug 5552) add a fulltext-only search mode to inputboxrainman02:53, 31 December 2008

Status & tagging log