r45028 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45027‎ | r45028 | r45029 >
Date:15:38, 25 December 2008
Author:ialex
Status:reverted (Comments)
Tags:
Comment:
oops, forgot summary-preview :(
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1327,7 +1327,6 @@
13281328 if ( $this->missingSummary ) $summaryhiddens .= Xml::hidden( 'wpIgnoreBlankSummary', true );
13291329 $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
13301330 $summaryhiddens .= Xml::hidden( 'wpAutoSummary', $autosumm );
1331 - $subjectPreviewMsg = wfMsgExt( 'subject-preview', array( 'escapenoentities' ) );
13321331 if ( $this->section == 'new' ) {
13331332 $commentsubject = "<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}</label></span>\n" .
13341333 "<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />" .
@@ -1336,7 +1335,8 @@
13371336 global $wgParser;
13381337 $formattedSummary = wfMsgForContent( 'newsectionsummary', $wgParser->stripSectionName( $this->summary ) );
13391338 $subjectpreview = $summarytext && $this->preview ?
1340 - "<div class=\"mw-summary-preview\">" . $subjectPreviewMsg . $sk->commentBlock( $formattedSummary, $this->mTitle, true ) . "</div>\n" : '';
 1339+ "<div class=\"mw-summary-preview\">" . wfMsgExt( 'subject-preview', array( 'escapenoentities' ) ) .
 1340+ $sk->commentBlock( $formattedSummary, $this->mTitle, true ) . "</div>\n" : '';
13411341 $summarypreview = '';
13421342 } else {
13431343 $commentsubject = '';
@@ -1345,7 +1345,8 @@
13461346 "{$summaryhiddens}<br />";
13471347 $subjectpreview = '';
13481348 $summarypreview = $summarytext && $this->preview ?
1349 - "<div class=\"mw-summary-preview\">" . $subjectPreviewMsg . $sk->commentBlock( $this->summary, $this->mTitle ) . "</div>\n" : '';
 1349+ "<div class=\"mw-summary-preview\">" . wfMsgExt( 'summary-preview', array( 'escapenoentities' ) ) .
 1350+ $sk->commentBlock( $this->summary, $this->mTitle ) . "</div>\n" : '';
13501351 }
13511352
13521353 # Set focus to the edit box on load, except on preview or diff, where it would interfere with the display
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1055,7 +1055,7 @@
10561056 'missingcommenttext' => 'Please enter a comment below.',
10571057 'missingcommentheader' => "'''Reminder:''' You have not provided a subject/headline for this comment.
10581058 If you click Save again, your edit will be saved without one.",
1059 -'summary-preview' => 'Summary preview',
 1059+'summary-preview' => 'Summary preview:',
10601060 'subject-preview' => 'Subject/headline preview:',
10611061 'blockedtitle' => 'User is blocked',
10621062 'blockedtext' => "<big>'''Your user name or IP address has been blocked.'''</big>

Follow-up revisions

RevisionCommit summaryAuthorDate
r45228Revert r45027, r45028 "* summary and subject messages now uses wiki text rath...brion17:10, 31 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   17:10, 31 December 2008

Reverted in r45228

Status & tagging log