r44972 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44971‎ | r44972 | r44973 >
Date:21:05, 23 December 2008
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
(Bug 16677) Media: view URLs should HTTP-redirect to canonical File: namespace
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
——@@ -218,6 +218,10 @@
219219 } else if( NS_SPECIAL == $title->getNamespace() ) {
220220 /* actions that need to be made when we have a special pages */
221221 SpecialPage::executePath( $title );
 222+ } else if( NS_MEDIA == $title->getNamespace() ) {
 223+ global $wgOut;
 224+ $fileTitle = Title::makeTitle( NS_FILE, $title->getDBKey() );
 225+ $wgOut->redirect( $fileTitle->getFullUrl() );
222226 } else {
223227 /* Try low-level file cache hit */
224228 if( $title->getNamespace() != NS_MEDIAWIKI && HTMLFileCache::useFileCache() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r44981Pull back r44972 for now "(Bug 16677) Media: view URLs should HTTP-redirect t...brion21:57, 23 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   21:58, 23 December 2008

Rolled back for now in r44981.

r44972 isn't quite behaving transparently; non-view URLs are also being redirected to the raw view page, so for instance an ?action=edit or diff or whatever gets lost.

See for example: http://en.wikipedia.org/wiki/Image:Wiki.png?action=edit http://en.wikipedia.org/wiki/Media:Wiki.png?action=edit

these both currently behave just like: http://en.wikipedia.org/wiki/File:Wiki.png?action=edit

while with this patch the Media: one would unexpectedly redirect to the view URL.

The redirection should probably just be done where other existing normalization is... perhaps all that's actually needed is just to replace a Media: Title with the equivalent File: one when initializing the title in the first place, and the existing normalization-redirection will take care of it.

Status & tagging log