r44971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44970‎ | r44971 | r44972 >
Date:21:01, 23 December 2008
Author:simetrical
Status:ok
Tags:
Comment:
Change "commentator" to "commenter"

A commentator is someone who professionally comments on things,
generally public affairs or news items. That's certainly not correct.
Between "commentor" (the previous spelling) and "commenter", the latter
seems to be preferable: the AHD has neither, but Webster's has
"commenter" and not "commentor", and "commenter" is the clear winner in
a Google fight.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/codereview.sql
@@ -146,7 +146,7 @@
147147 -- cc_id of parent comment if a threaded child, otherwise NULL
148148 cc_parent int,
149149
150 - -- User id/name of the commentor
 150+ -- User id/name of the commenter
151151 cc_user int not null,
152152 cc_user_text varchar(255) not null,
153153
@@ -189,7 +189,7 @@
190190 -- Timestamp of the change, in MediaWiki format.
191191 cpc_timestamp binary(14) not null default '',
192192
193 - -- User id/name of the commentor
 193+ -- User id/name of the commenter
194194 cpc_user int not null,
195195 cpc_user_text varchar(255) not null,
196196
Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -34,7 +34,7 @@
3535 'code-author-unlinksuccess' => 'Author $1 has been unlinked',
3636 'code-field-id' => 'Revision',
3737 'code-field-author' => 'Author',
38 - 'code-field-user' => 'Commentator',
 38+ 'code-field-user' => 'Commenter',
3939 'code-field-message' => 'Commit summary',
4040 'code-field-status' => 'Status',
4141 'code-field-timestamp' => 'Date',
Index: trunk/extensions/CodeReview/CodeRevision.php
@@ -227,7 +227,7 @@
228228 $commentId = $dbw->insertId();
229229 $dbw->commit();
230230
231 - // Give email notices to committer and commentors
 231+ // Give email notices to committer and commenters
232232 global $wgCodeReviewENotif, $wgEnableEmail;
233233 if( $wgCodeReviewENotif && $wgEnableEmail ) {
234234 // Make list of users to send emails to
@@ -240,7 +240,7 @@
241241 $title->setFragment( "#c{$commentId}" );
242242 $url = $title->getFullUrl();
243243 foreach( $users as $userId => $user ) {
244 - // No sense in notifying this commentor
 244+ // No sense in notifying this commenter
245245 if( $wgUser->getId() == $user->getId() ) {
246246 continue;
247247 }

Status & tagging log