r44970 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44969‎ | r44970 | r44971 >
Date:20:56, 23 December 2008
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Add FileCache exit back from r44801
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
——@@ -235,7 +235,8 @@
236236 $article->viewUpdates();
237237 }
238238 wfProfileOut( __METHOD__ );
239 - return true;
 239+ $this->restInPeace();
 240+ exit;
240241 }
241242 }
242243 /* No match to special cases */

Follow-up revisions

RevisionCommit summaryAuthorDate
r44980Revert r44970 "Add FileCache exit back from r44801"...brion21:50, 23 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44801Tweaks from profilingaaron09:21, 19 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   21:50, 23 December 2008

Forcing an exit from the middle of an initialization function seems like pretty poor practice. Reverted in r44980

Status & tagging log