r44292 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44291‎ | r44292 | r44293 >
Date:21:57, 7 December 2008
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Assign by ref to make sure cache fields carry over
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -265,7 +265,7 @@
266266
267267 function setMembers(){
268268 global $wgTitle, $wgUser;
269 - $this->mTitle = $wgTitle;
 269+ $this->mTitle =& $wgTitle;
270270 $this->mUser = $wgUser;
271271 $this->userpage = $wgUser->getUserPage()->getPrefixedText();
272272 $this->usercss = false;

Follow-up revisions

RevisionCommit summaryAuthorDate
r44434Revert r44292 "Assign by ref to make sure cache fields carry over"...brion23:29, 10 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   23:30, 10 December 2008

This isn't PHP 4; the object's fields are changed on the object itself just fine. Unless people are changing the global variable $wgTitle to something different this should be fine. If there is a problem that this fixes, that's probably a problem itself and should be fixed in a cleaner way :D

Reverted in r44434.

Status & tagging log