r44434 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44433‎ | r44434 | r44435 >
Date:23:29, 10 December 2008
Author:brion
Status:ok
Tags:
Comment:
Revert r44292 "Assign by ref to make sure cache fields carry over"
This isn't PHP 4; the object's fields are changed on the object itself just fine. Unless people are changing the global variable $wgTitle to something different this should be fine. If there is a problem that this fixes, that's probably a problem itself and should be fixed in a cleaner way :D
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -266,7 +266,7 @@
267267
268268 function setMembers(){
269269 global $wgTitle, $wgUser;
270 - $this->mTitle =& $wgTitle;
 270+ $this->mTitle = $wgTitle;
271271 $this->mUser = $wgUser;
272272 $this->userpage = $wgUser->getUserPage()->getPrefixedText();
273273 $this->usercss = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44292Assign by ref to make sure cache fields carry overaaron21:57, 7 December 2008

Status & tagging log