r43639 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r43638‎ \| r43639 \| r43640 >
Date:	21:27, 17 November 2008
Author:	siebrand
Status:	ok (Comments)
Tags:
Comment:	(bug 44) Rename Image namespace to File. Based on a patch by brion. * Parser tests updated. 14 failing parser tests before the change, added one, and the same 14 failing parser tests are remaining * added namespace aliases for Image and Image_talk for backward compatibility purposes
Modified paths:	/trunk/extensions/Cite/citeParserTests.txt (modified) (history) /trunk/phase3/RELEASE-NOTES (modified) (history) /trunk/phase3/includes/Namespace.php (modified) (history) /trunk/phase3/languages/messages/MessagesEn.php (modified) (history) /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
—	—	@@ -2335,7 +2335,7 @@
2336	2336	{{paramtest\|
2337	2337	param =[[Image:noimage.png\|thumb\|[[no link\|link]] [[no link\|caption]]]]}}
2338	2338	!! result
2339		-This is a test template with parameter <div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/index.php?title=Special:Upload&wpDestFile=Noimage.png" class="new" title="Image:Noimage.png">Image:Noimage.png</a> <div class="thumbcaption"><a href="https://www.mediawiki.org/index.php?title=No_link&action=edit&redlink=1" class="new" title="No link (not yet written)">link</a> <a href="https://www.mediawiki.org/index.php?title=No_link&action=edit&redlink=1" class="new" title="No link (not yet written)">caption</a></div></div></div>
	2339	+This is a test template with parameter <div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/index.php?title=Special:Upload&wpDestFile=Noimage.png" class="new" title="File:Noimage.png">File:Noimage.png</a> <div class="thumbcaption"><a href="https://www.mediawiki.org/index.php?title=No_link&action=edit&redlink=1" class="new" title="No link (not yet written)">link</a> <a href="https://www.mediawiki.org/index.php?title=No_link&action=edit&redlink=1" class="new" title="No link (not yet written)">caption</a></div></div></div>
2340	2340
2341	2341	!! end
2342	2342
—	—	@@ -3072,7 +3072,7 @@
3073	3073	!! input
3074	3074	[[Image:foobar.jpg]]
3075	3075	!! result
3076		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3076	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3077	3077	</p>
3078	3078	!! end
3079	3079
—	—	@@ -3081,16 +3081,25 @@
3082	3082	!! input
3083	3083	[[Image:foobar.jpg\|right]]
3084	3084	!! result
3085		-<div class="floatright"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
	3085	+<div class="floatright"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
3086	3086
3087	3087	!! end
3088	3088
3089	3089	!! test
	3090	+Simple image (using File: namespace, now canonical)
	3091	+!! input
	3092	+[[File:foobar.jpg]]
	3093	+!! result
	3094	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="File:foobar.jpg"><img alt="File:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3095	+</p>
	3096	+!! end
	3097	+
	3098	+!! test
3090	3099	Image with caption
3091	3100	!! input
3092	3101	[[Image:foobar.jpg\|right\|Caption text]]
3093	3102	!! result
3094		-<div class="floatright"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Caption text"><img alt="Caption text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
	3103	+<div class="floatright"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Caption text"><img alt="Caption text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
3095	3104
3096	3105	!! end
3097	3106
—	—	@@ -3128,7 +3137,7 @@
3129	3138	!! input
3130	3139	[[Image:Foobar.jpg\|frame\|left\|This is a test image [[Main Page]]]]
3131	3140	!! result
3132		-<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="This is a test image Main Page"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
	3141	+<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a test image Main Page"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
3133	3142
3134	3143	!! end
3135	3144
—	—	@@ -3137,7 +3146,7 @@
3138	3147	!! input
3139	3148	[[Image:Foobar.jpg\|frame\|left\|This is a test image [[Main Page]]\|alt=Altitude]]
3140	3149	!! result
3141		-<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="This is a test image Main Page"><img alt="Altitude" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
	3150	+<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a test image Main Page"><img alt="Altitude" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
3142	3151
3143	3152	!! end
3144	3153
—	—	@@ -3146,7 +3155,7 @@
3147	3156	!! input
3148	3157	[[Image:Foobar.jpg\|testing '''bold''' in alt]]
3149	3158	!! result
3150		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="testing bold in alt"><img alt="testing bold in alt" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3159	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="testing bold in alt"><img alt="testing bold in alt" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3151	3160	</p>
3152	3161	!! end
3153	3162
—	—	@@ -3155,18 +3164,18 @@
3156	3165	!! input
3157	3166	[[Image:Foobar.jpg\|alt=testing '''bold''' in alt]]
3158	3167	!! result
3159		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="testing bold in alt" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3168	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="testing bold in alt" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3160	3169	</p>
3161	3170	!! end
3162	3171
3163	3172	!! test
3164	3173	Link to image page- image page normally doesn't exists, hence edit link
3165	3174	Add test with existing image page
3166		~~-#<p><a href="https://www.mediawiki.org/wiki/Image:Test" title="Image:Test">Image:test</a>~~
	3175	+#<p><a href="https://www.mediawiki.org/wiki/File:Test" title="Image:Test">Image:test</a>
3167	3176	!! input
3168	3177	[[:Image:test]]
3169	3178	!! result
3170		~~-<p><a href="https://www.mediawiki.org/index.php?title=Image:Test&action=edit&redlink=1" class="new" title="Image:Test (not yet written)">Image:test</a>~~
	3179	+<p><a href="https://www.mediawiki.org/index.php?title=File:Test&action=edit&redlink=1" class="new" title="File:Test (not yet written)">Image:test</a>
3171	3180	</p>
3172	3181	!! end
3173	3182
—	—	@@ -3175,7 +3184,7 @@
3176	3185	!! input
3177	3186	[[Image:foobar.jpg\|http://example.com]]
3178	3187	!! result
3179		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="http://example.com"><img alt="http://example.com" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3188	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="http://example.com" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3180	3189	</p>
3181	3190	!! end
3182	3191
—	—	@@ -3184,7 +3193,7 @@
3185	3194	!! input
3186	3195	[[Image:foobar.jpg\|thumb\|http://example.com]]
3187	3196	!! result
3188		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="http://example.com"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a></div></div></div>
	3197	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a></div></div></div>
3189	3198
3190	3199	!! end
3191	3200
—	—	@@ -3193,7 +3202,7 @@
3194	3203	!! input
3195	3204	[[Image:foobar.jpg\|thumb\|http://example.com\|alt=Alteration]]
3196	3205	!! result
3197		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="http://example.com"><img alt="Alteration" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a></div></div></div>
	3206	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="Alteration" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a></div></div></div>
3198	3207
3199	3208	!! end
3200	3209
—	—	@@ -3202,7 +3211,7 @@
3203	3212	!! input
3204	3213	[[Image:foobar.jpg\|thumb\|ISBN 1235467890]]
3205	3214	!! result
3206		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="ISBN 1235467890"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="https://www.mediawiki.org/wiki/Special:BookSources/1235467890" class="internal">ISBN 1235467890</a></div></div></div>
	3215	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="ISBN 1235467890"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="https://www.mediawiki.org/wiki/Special:BookSources/1235467890" class="internal">ISBN 1235467890</a></div></div></div>
3207	3216
3208	3217	!! end
3209	3218
—	—	@@ -3211,7 +3220,7 @@
3212	3221	!! input
3213	3222	[[Image:foobar.jpg\|thumb\|This is RFC 12354]]
3214	3223	!! result
3215		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="This is RFC 12354"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This is <a href="http://tools.ietf.org/html/rfc12354" class="external" title="http://tools.ietf.org/html/rfc12354">RFC 12354</a></div></div></div>
	3224	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is RFC 12354"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This is <a href="http://tools.ietf.org/html/rfc12354" class="external" title="http://tools.ietf.org/html/rfc12354">RFC 12354</a></div></div></div>
3216	3225
3217	3226	!! end
3218	3227
—	—	@@ -3220,7 +3229,7 @@
3221	3230	!! input
3222	3231	[[Image:foobar.jpg\|thumb\|Please mailto:nobody@example.com]]
3223	3232	!! result
3224		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Please mailto:nobody@example.com"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>Please <a href="mailto:nobody@example.com" class="external free" title="mailto:nobody@example.com" rel="nofollow">mailto:nobody@example.com</a></div></div></div>
	3233	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Please mailto:nobody@example.com"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>Please <a href="mailto:nobody@example.com" class="external free" title="mailto:nobody@example.com" rel="nofollow">mailto:nobody@example.com</a></div></div></div>
3225	3234
3226	3235	!! end
3227	3236
—	—	@@ -3230,7 +3239,7 @@
3231	3240	!! input
3232	3241	[[Image:foobar.jpg\|thumb\|<math>2+2</math>]]
3233	3242	!! result
3234		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="<math>2+2</math>"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><math>2+2</math></div></div></div>
	3243	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="<math>2+2</math>"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><math>2+2</math></div></div></div>
3235	3244
3236	3245	!! end
3237	3246
—	—	@@ -3241,7 +3250,7 @@
3242	3251	!! input
3243	3252	[[Image:foobar.jpg\|thumb\|<math>2+2</math>]]
3244	3253	!! result
3245		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="2 + 2"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><span class="texhtml">2 + 2</span></div></div></div>
	3254	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="2 + 2"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><span class="texhtml">2 + 2</span></div></div></div>
3246	3255
3247	3256	!! end
3248	3257
—	—	@@ -3251,7 +3260,7 @@
3252	3261	!! input
3253	3262	[[Image:foobar.jpg\|text with a [[link]] in it]]
3254	3263	!! result
3255		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="text with a link in it"><img alt="text with a link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3264	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a link in it"><img alt="text with a link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3256	3265	</p>
3257	3266	!! end
3258	3267
—	—	@@ -3260,7 +3269,7 @@
3261	3270	!! input
3262	3271	[[Image:foobar.jpg\|text with a [[link]]foo in it]]
3263	3272	!! result
3264		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="text with a linkfoo in it"><img alt="text with a linkfoo in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3273	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a linkfoo in it"><img alt="text with a linkfoo in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3265	3274	</p>
3266	3275	!! end
3267	3276
—	—	@@ -3269,7 +3278,7 @@
3270	3279	!! input
3271	3280	[[Image:foobar.jpg\|text with a [[MeatBall:Link]] in it]]
3272	3281	!! result
3273		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="text with a MeatBall:Link in it"><img alt="text with a MeatBall:Link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3282	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a MeatBall:Link in it"><img alt="text with a MeatBall:Link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3274	3283	</p>
3275	3284	!! end
3276	3285
—	—	@@ -3278,7 +3287,7 @@
3279	3288	!! input
3280	3289	[[Image:foobar.jpg\|text with a [[MeatBall:Link\|link]] in it]]
3281	3290	!! result
3282		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="text with a link in it"><img alt="text with a link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3291	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a link in it"><img alt="text with a link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3283	3292	</p>
3284	3293	!! end
3285	3294
—	—	@@ -3287,7 +3296,7 @@
3288	3297	!! input
3289	3298	[[Image:foobar.jpg\|& < > "]]
3290	3299	!! result
3291		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="& < > ""><img alt="& < > "" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3300	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="& < > ""><img alt="& < > "" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3292	3301	</p>
3293	3302	!! end
3294	3303
—	—	@@ -3296,7 +3305,7 @@
3297	3306	!! input
3298	3307	[[Image:foobar.jpg\|♀]]
3299	3308	!! result
3300		~~-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="♀"><img alt="♀" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>~~
	3309	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="♀"><img alt="♀" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3301	3310	</p>
3302	3311	!! end
3303	3312
—	—	@@ -3314,7 +3323,7 @@
3315	3324	!! input
3316	3325	[[Image:Foobar.jpg\|thumb\|This is a caption with another [[Image:icon.png\|image]] inside it!]]
3317	3326	!! result
3318		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="This is a caption with another Image:Icon.png inside it!"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This is a caption with another <a href="https://www.mediawiki.org/index.php?title=Special:Upload&wpDestFile=Icon.png" class="new" title="Image:Icon.png">Image:Icon.png</a> inside it!</div></div></div>
	3327	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a caption with another File:Icon.png inside it!"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This is a caption with another <a href="https://www.mediawiki.org/index.php?title=Special:Upload&wpDestFile=Icon.png" class="new" title="File:Icon.png">File:Icon.png</a> inside it!</div></div></div>
3319	3328
3320	3329	!! end
3321	3330
—	—	@@ -3324,7 +3333,7 @@
3325	3334	[[Image:Foobar.jpg\|This
3326	3335	*is some text]]
3327	3336	!! result
3328		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="This is some text"><img alt="This is some text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3337	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is some text"><img alt="This is some text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3329	3338	</p>
3330	3339	!!end
3331	3340
—	—	@@ -3334,7 +3343,7 @@
3335	3344	!! input
3336	3345	[[Image:Foobar.jpg\|thumb\|200px\|This caption has [irc://example.net irc] and [https://example.com Secure] ext links in it.]]
3337	3346	!! result
3338		-<div class="thumb tright"><div class="thumbinner" style="width:202px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="This caption has irc and Secure ext links in it."><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/200px-Foobar.jpg" width="200" height="23" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This caption has <a href="irc://example.net" class="external text" title="irc://example.net" rel="nofollow">irc</a> and <a href="https://example.com" class="external text" title="https://example.com" rel="nofollow">Secure</a> ext links in it.</div></div></div>
	3347	+<div class="thumb tright"><div class="thumbinner" style="width:202px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This caption has irc and Secure ext links in it."><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/200px-Foobar.jpg" width="200" height="23" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This caption has <a href="irc://example.net" class="external text" title="irc://example.net" rel="nofollow">irc</a> and <a href="https://example.com" class="external text" title="https://example.com" rel="nofollow">Secure</a> ext links in it.</div></div></div>
3339	3348
3340	3349	!! end
3341	3350
—	—	@@ -3737,7 +3746,7 @@
3738	3747	!! input
3739	3748	http://example.com [[Image:foobar.jpg]]
3740	3749	!! result
3741		-<p><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a> <a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3750	+<p><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a> <a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3742	3751	</p>
3743	3752	!!end
3744	3753
—	—	@@ -3746,7 +3755,7 @@
3747	3756	!! input
3748	3757	http://example.com[[Image:foobar.jpg]]
3749	3758	!! result
3750		-<p><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3759	+<p><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
3751	3760	</p>
3752	3761	!!end
3753	3762
—	—	@@ -3932,7 +3941,7 @@
3933	3942	!! input
3934	3943	[[Image:No such.jpg]]
3935	3944	!! result
3936		~~-<p><a href="https://www.mediawiki.org/index.php?title=Special:Upload&wpDestFile=No_such.jpg" class="new" title="Image:No such.jpg">Image:No such.jpg</a>~~
	3945	+<p><a href="https://www.mediawiki.org/index.php?title=Special:Upload&wpDestFile=No_such.jpg" class="new" title="File:No such.jpg">File:No such.jpg</a>
3937	3946	</p>
3938	3947	!! end
3939	3948
—	—	@@ -3941,7 +3950,7 @@
3942	3951	!! input
3943	3952	[[:Image:No such.jpg]]
3944	3953	!! result
3945		~~-<p><a href="https://www.mediawiki.org/index.php?title=Image:No_such.jpg&action=edit&redlink=1" class="new" title="Image:No such.jpg (not yet written)">Image:No such.jpg</a>~~
	3954	+<p><a href="https://www.mediawiki.org/index.php?title=File:No_such.jpg&action=edit&redlink=1" class="new" title="File:No such.jpg (not yet written)">Image:No such.jpg</a>
3946	3955	</p>
3947	3956	!! end
3948	3957
—	—	@@ -6254,7 +6263,7 @@
6255	6264	!! input
6256	6265	[[Image:foobar.jpg\|centre]]
6257	6266	!! result
6258		-<div class="center"><div class="floatnone"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div></div>
	6267	+<div class="center"><div class="floatnone"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div></div>
6259	6268
6260	6269	!!end
6261	6270
—	—	@@ -6263,7 +6272,7 @@
6264	6273	!! input
6265	6274	[[Image:foobar.jpg\|none]]
6266	6275	!! result
6267		-<div class="floatnone"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
	6276	+<div class="floatnone"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
6268	6277
6269	6278	!!end
6270	6279
—	—	@@ -6272,7 +6281,7 @@
6273	6282	!! input
6274	6283	[[Image:foobar.jpg\|640x480px]]
6275	6284	!! result
6276		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
	6285	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
6277	6286	</p>
6278	6287	!!end
6279	6288
—	—	@@ -6281,7 +6290,7 @@
6282	6291	!! input
6283	6292	[[Image:foobar.jpg\|640px]]
6284	6293	!! result
6285		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
	6294	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
6286	6295	</p>
6287	6296	!!end
6288	6297
—	—	@@ -6290,7 +6299,7 @@
6291	6300	!! input
6292	6301	[[Image:foobar.jpg\|640px ]]
6293	6302	!! result
6294		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
	6303	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
6295	6304	</p>
6296	6305	!!end
6297	6306
—	—	@@ -6299,7 +6308,7 @@
6300	6309	!! input
6301	6310	[[Image:foobar.jpg\| 640px]]
6302	6311	!! result
6303		-<p><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
	6312	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
6304	6313	</p>
6305	6314	!!end
6306	6315
—	—	@@ -6337,7 +6346,7 @@
6338	6347	!! input
6339	6348	[[image:Foobar.jpg\|thumb\|An [http://test/?param1=\|left\|&param2=\|x external] URL]]
6340	6349	!! result
6341		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="An external URL"><img alt="An external URL" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>An <a href="http://test/?param1=\|left\|&param2=\|x" class="external text" title="http://test/?param1=\|left\|&param2=\|x" rel="nofollow">external</a> URL</div></div></div>
	6350	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="An external URL"><img alt="An external URL" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>An <a href="http://test/?param1=\|left\|&param2=\|x" class="external text" title="http://test/?param1=\|left\|&param2=\|x" rel="nofollow">external</a> URL</div></div></div>
6342	6351
6343	6352	!!end
6344	6353
—	—	@@ -7151,7 +7160,7 @@
7152	7161	!! input
7153	7162	[[Image:Foobar.jpg\|thumb\|http://x\|hello]]
7154	7163	!! result
7155		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="hello"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>hello</div></div></div>
	7164	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="hello"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>hello</div></div></div>
7156	7165
7157	7166	!! end
7158	7167
Index: trunk/phase3/includes/Namespace.php
—	—	@@ -16,8 +16,8 @@
17	17	NS_USER_TALK => 'User_talk',
18	18	NS_PROJECT => 'Project',
19	19	NS_PROJECT_TALK => 'Project_talk',
20		~~- NS_IMAGE => 'Image',~~
21		~~- NS_IMAGE_TALK => 'Image_talk',~~
	20	+ NS_IMAGE => 'File',
	21	+ NS_IMAGE_TALK => 'File_talk',
22	22	NS_MEDIAWIKI => 'MediaWiki',
23	23	NS_MEDIAWIKI_TALK => 'MediaWiki_talk',
24	24	NS_TEMPLATE => 'Template',
Index: trunk/phase3/languages/messages/MessagesEn.php
—	—	@@ -86,8 +86,8 @@
87	87	NS_USER_TALK => 'User_talk',
88	88	# NS_PROJECT set by $wgMetaNamespace
89	89	NS_PROJECT_TALK => '$1_talk',
90		~~- NS_IMAGE => 'Image',~~
91		~~- NS_IMAGE_TALK => 'Image_talk',~~
	90	+ NS_IMAGE => 'File',
	91	+ NS_IMAGE_TALK => 'File_talk',
92	92	NS_MEDIAWIKI => 'MediaWiki',
93	93	NS_MEDIAWIKI_TALK => 'MediaWiki_talk',
94	94	NS_TEMPLATE => 'Template',
—	—	@@ -101,7 +101,10 @@
102	102	/**
103	103	* Array of namespace aliases, mapping from name to NS_xxx index
104	104	*/
105		~~-$namespaceAliases = array();~~
	105	+$namespaceAliases = array(
	106	+ 'Image' => NS_IMAGE,
	107	+ 'Image_talk' => NS_IMAGE_TALK,
	108	+);
106	109
107	110	/**
108	111	* Skin names. If any key is not specified, the English one will be used.
Index: trunk/phase3/RELEASE-NOTES
—	—	@@ -60,6 +60,9 @@
61	61	on the user's real name if one is set. Defaults to false (use the username)
62	62	* Removed the 'apiThumbCacheDir' option from $wgForeignFileRepos (only used in
63	63	ForeignAPIRepo)
	64	+* Image namespace and accompanying talk namespace renamed to File. For backward
	65	+ compatibility purposes, Image still works. External tools may need to be
	66	+ updated.
64	67
65	68	=== Migrated extensions ===
66	69	The following extensions are migrated into MediaWiki 1.14:
—	—	@@ -197,8 +200,8 @@
198	201	* (bug 16113) Show/hide for redirects in Special:NewPages
199	202	* (bug 15903) Upload link was added to Nostalgia skin
200	203	* (bug 15761) Add user toggle to omit diff after rollback
201		~~-* Added the BitmapHandler_ClientOnly media handler, which allows server-side~~
202		~~- image scaling to be completely disabled for specific media types, via the~~
	204	+* Added the BitmapHandler_ClientOnly media handler, which allows server-side
	205	+ image scaling to be completely disabled for specific media types, via the
203	206	$wgMediaHandlers configuration variable.
204	207	* New 'AbortDiffCache' hook can be used to cancel the caching of a diff
205	208	* (bug 15835) Added Content-Style-Type meta tag
—	—	@@ -336,11 +339,11 @@
337	340	search box
338	341	* (bug 4362) [[MediaWiki:History copyright]] no more used with most recent
339	342	revision when passing oldid parameter in the url
340		~~-* (bug 16265) When caching thumbs with the ForeignApiRepo, we now use the same~~
	343	+* (bug 16265) When caching thumbs with the ForeignApiRepo, we now use the same
341	344	filename as the remote site.
342	345	* (bug 8345) Don't autosummarize where a redirect was left unchanged
343	346	* Made thumb caching in ForeignApiFile objects integrated with normal thumb
344		~~- path naming (/thumbs/hash/file), retired 'apiThumbCacheDir' as a result.~~
	347	+ path naming (/thumbs/hash/file), retired 'apiThumbCacheDir' as a result.
345	348	* (bug 5530) Consistency between character encoding in {{PAGENAMEE}},
346	349	{{SUBPAGENAMEE}} and {{FULLPAGENAMEE}}
347	350	* API siteinfo query no longer throws an exception for empty sifilter parameter.
Index: trunk/extensions/Cite/citeParserTests.txt
—	—	@@ -112,7 +112,7 @@
113	113	<table class="gallery" cellspacing="0" cellpadding="0">
114	114	<tr>
115	115	<td><div class="gallerybox" style="width: 155px;">
116		- <div class="thumb" style="padding: 66px 0; width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" width="120" height="14" border="0" /></a></div></div>
	116	+ <div class="thumb" style="padding: 66px 0; width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" width="120" height="14" border="0" /></a></div></div>
117	117	<div class="gallerytext">
118	118	</div>
119	119	</div></td>

Follow-up revisions

Revision	Commit summary	Author	Date
r43806	Revert r43785 (switching hardcoded Image: to loading the canonical name). Thi...	demon	09:24, 21 November 2008
r44001	(bug 44) make 'Image' and 'Image_talk' compatibility aliases work for all lan...	vyznev	20:27, 27 November 2008
r44004	First step in replacing NS_IMAGE with NS_FILE, to match the canonical name ch...	vyznev	22:36, 27 November 2008
r44121	Step 2 in NS_IMAGE -> NS_FILE transition (bug 44) (WARNING: huge commit)....	vyznev	17:14, 1 December 2008
r44122	bug 44 related change: NS_IMAGE -> NS_FILE	siebrand	18:03, 1 December 2008
r44495	(bug 44) Fix omission: Image -> File in namespace names for yue, zh-hans, and...	siebrand	11:11, 12 December 2008
r44508	Manual exporting namespaces aliases from Betawiki (bug 44: renaming of Image ...	ialex	18:21, 12 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs) 23:28, 21 November 2008

woohoo

Status & tagging log

23:28, 21 November 2008 Brion VIBBER (talk | contribs) changed the status of r43639 [removed: new added: ok]