r44001 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44000‎ | r44001 | r44002 >
Date:20:27, 27 November 2008
Author:vyznev
Status:ok
Tags:
Comment:
(bug 44) make 'Image' and 'Image_talk' compatibility aliases work for all languages, not just English
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -68,6 +68,14 @@
6969 $wgNamespaceProtection[NS_MEDIAWIKI] = 'editinterface';
7070
7171 /**
 72+ * The canonical names of namespaces 6 and 7 are, as of v1.14, "File"
 73+ * and "File_talk". The old names "Image" and "Image_talk" are
 74+ * retained as aliases for backwards compatibility.
 75+ */
 76+$wgNamespaceAliases['Image'] = NS_IMAGE;
 77+$wgNamespaceAliases['Image_talk'] = NS_IMAGE_TALK;
 78+
 79+/**
7280 * Initialise $wgLocalFileRepo from backwards-compatible settings
7381 */
7482 if ( !$wgLocalFileRepo ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -101,10 +101,7 @@
102102 /**
103103 * Array of namespace aliases, mapping from name to NS_xxx index
104104 */
105 -$namespaceAliases = array(
106 - 'Image' => NS_IMAGE,
107 - 'Image_talk' => NS_IMAGE_TALK,
108 -);
 105+$namespaceAliases = array();
109106
110107 /**
111108 * Skin names. If any key is not specified, the English one will be used.

Follow-up revisions

RevisionCommit summaryAuthorDate
r44004First step in replacing NS_IMAGE with NS_FILE, to match the canonical name ch...vyznev22:36, 27 November 2008
r44121Step 2 in NS_IMAGE -> NS_FILE transition (bug 44) (WARNING: huge commit)....vyznev17:14, 1 December 2008
r44122bug 44 related change: NS_IMAGE -> NS_FILEsiebrand18:03, 1 December 2008
r44495(bug 44) Fix omission: Image -> File in namespace names for yue, zh-hans, and...siebrand11:11, 12 December 2008
r44508Manual exporting namespaces aliases from Betawiki (bug 44: renaming of Image ...ialex18:21, 12 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43639(bug 44) Rename Image namespace to File. Based on a patch by brion....siebrand21:27, 17 November 2008

Status & tagging log