r42210 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r42209‎ | r42210 | r42211 >
Date:21:28, 18 October 2008
Author:raymond
Status:old (Comments)
Tags:
Comment:
* (bug 16015) Change parsing of MediaWiki:Categorytree-member-num to allow &nbsp;
Modified paths:
  • /trunk/extensions/CategoryTree/CategoryTreeFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryTree/CategoryTreeFunctions.php
——@@ -698,7 +698,7 @@
699699
700700 $s .= ' ';
701701 global $wgLang;
702 - $s .= Xml::element( 'span', $attr, wfMsgExt( 'categorytree-member-num', 'parsemag', $cat->getSubcatCount(), $pages , $cat->getFileCount(), $cat->getPageCount(), $wgLang->formatNum( $count ) ) );
 702+ $s .= Xml::tags( 'span', $attr, wfMsgExt( 'categorytree-member-num', array( 'parseinline', 'escapenoentities' ), $cat->getSubcatCount(), $pages , $cat->getFileCount(), $cat->getPageCount(), $wgLang->formatNum( $count ) ) );
703703 }
704704
705705 $s .= Xml::closeElement( 'div' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r42244Cleanup r42210 "* (bug 16015) Change parsing of MediaWiki:Categorytree-member...brion00:57, 20 October 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   00:58, 20 October 2008

'parsemag' was mysteriously changed here to 'parseinline', which is incorrect given that the result is HTML-escaped with 'escapenoenities' -- they don't play nicely together. :)

Changed it back to 'parsemag' in r42244. 'parseinline' *without* 'escapenoentities' might also seem like a good choice, but didn't seem to be what was intended.

Also broke the very very very long line for legibility.

Status & tagging log