r42244 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r42243‎ | r42244 | r42245 >
Date:00:57, 20 October 2008
Author:brion
Status:old
Tags:
Comment:
Cleanup r42210 "* (bug 16015) Change parsing of MediaWiki:Categorytree-member-num to allow &nbsp;"

'parsemag' was mysteriously chaned to 'parseinline', which is incorrect given that the result is HTML-escaped with 'escapenoenities' -- they don't play nicely together. :)

Changed it back to 'parsemag'. 'parseinline' *without* 'escapenoentities' might also seem like a good choice, but didn't seem to be what was intended.

Also broke the very very very long line for legibility.
Modified paths:
  • /trunk/extensions/CategoryTree/CategoryTreeFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryTree/CategoryTreeFunctions.php
——@@ -698,7 +698,14 @@
699699
700700 $s .= ' ';
701701 global $wgLang;
702 - $s .= Xml::tags( 'span', $attr, wfMsgExt( 'categorytree-member-num', array( 'parseinline', 'escapenoentities' ), $cat->getSubcatCount(), $pages , $cat->getFileCount(), $cat->getPageCount(), $wgLang->formatNum( $count ) ) );
 702+ $s .= Xml::tags( 'span', $attr,
 703+ wfMsgExt( 'categorytree-member-num',
 704+ array( 'parsemag', 'escapenoentities' ),
 705+ $cat->getSubcatCount(),
 706+ $pages,
 707+ $cat->getFileCount(),
 708+ $cat->getPageCount(),
 709+ $wgLang->formatNum( $count ) ) );
703710 }
704711
705712 $s .= Xml::closeElement( 'div' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42210* (bug 16015) Change parsing of MediaWiki:Categorytree-member-num to allow &n...raymond21:28, 18 October 2008

Status & tagging log