r42037 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r42036‎ | r42037 | r42038 >
Date:15:40, 13 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Improve hidden field checks for bug 1181
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
——@@ -574,7 +574,7 @@
575575
576576 $this->scrolltop = $request->getIntOrNull( 'wpScrolltop' );
577577
578 - if ( is_null( $this->edittime ) ) {
 578+ if ( is_null($this->section) || !$this->edittime || !$this->starttime ) {
579579 # If the form is incomplete, force to preview.
580580 wfDebug( "$fname: Form data appears to be incomplete\n" );
581581 wfDebug( "POST DATA: " . var_export( $_POST, true ) . "\n" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r42569Revert r42037 "Improve hidden field checks for bug 1181"...brion20:09, 25 October 2008
r45809(bug 1181) Don't try to replace the whole page with one section if replaceSec...aaron19:56, 16 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   18:58, 13 October 2008

Section, edittime, and starttime all appear before the textarea these days, so there shouldn't be much need for this particular check. Doesn't hurt, I suppose, but I'm not convinced it's going to help anything.

#Comment by Brion VIBBER (talk | contribs)   20:06, 25 October 2008

This is causing trouble with bot edit tools, and since it doesn't have any benefit I can see anyway I'm going to back it out for now.

#Comment by Siebrand (talk | contribs)   09:27, 27 October 2008

Reverted in r42569

Status & tagging log