r42569 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r42568‎ | r42569 | r42570 >
Date:20:09, 25 October 2008
Author:brion
Status:old
Tags:
Comment:
Revert r42037 "Improve hidden field checks for bug 1181"
I don't think this check has any real benefit, since in the form the fields appear before the text box there's basically no way to submit the form without them. However the more stringent checks are causing disruption to bot edit tools, which annoys people, so I'm backing it out for the time being.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
——@@ -566,7 +566,7 @@
567567
568568 $this->scrolltop = $request->getIntOrNull( 'wpScrolltop' );
569569
570 - if ( is_null($this->section) || !$this->edittime || !$this->starttime ) {
 570+ if ( is_null( $this->edittime ) ) {
571571 # If the form is incomplete, force to preview.
572572 wfDebug( "$fname: Form data appears to be incomplete\n" );
573573 wfDebug( "POST DATA: " . var_export( $_POST, true ) . "\n" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r45809(bug 1181) Don't try to replace the whole page with one section if replaceSec...aaron19:56, 16 January 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42037Improve hidden field checks for bug 1181aaron15:40, 13 October 2008

Status & tagging log