r42010 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42009‎ | r42010 | r42011 >
Date:01:09, 13 October 2008
Author:danny_b
Status:old (Comments)
Tags:
Comment:
* + missing required alt attribute; currently empty, but it should contain something though because of accessibility
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -821,18 +821,18 @@
822822 <a class="removeLink" href="javascript:void(0)" title="$remove"><img src="$removeImage" width="11" height="11" alt="$remove" /></a>
823823 &nbsp;
824824 <a class="moveUpLink" href="javascript:void(0)" title="$moveUp"><img src="$moveUpImage" width="11" height="11" alt="$moveUp" /></a>
825 - <img class="moveUpDisabled" src="$moveDisabledImage" width="11" height="11" />
 825+ <img class="moveUpDisabled" src="$moveDisabledImage" width="11" height="11" alt="" />
826826 <a class="moveDownLink" href="javascript:void(0)" title="$moveDown"><img src="$moveDownImage" width="11" height="11" alt="$moveDown" /></a>
827 - <img class="moveDownDisabled" src="$moveDisabledImage" width="11" height="11" />
 827+ <img class="moveDownDisabled" src="$moveDisabledImage" width="11" height="11" alt="" />
828828 <a class="articleLink" style="margin-left:1em;"></a>
829829 </div>
830830 <div id="chapterListItem" class="chapter" style="margin-top:0.3em;">
831831 <a class="removeLink" href="javascript:void(0)" title="$remove"><img src="$removeImage" width="11" height="11" alt="$remove" /></a>
832832 &nbsp;
833833 <a class="moveUpLink" href="javascript:void(0)" title="$moveUp"><img src="$moveUpImage" width="11" height="11" alt="$moveUp" /></a>
834 - <img class="moveUpDisabled" src="$moveDisabledImage" width="11" height="11" />
 834+ <img class="moveUpDisabled" src="$moveDisabledImage" width="11" height="11" alt="" />
835835 <a class="moveDownLink" href="javascript:void(0)" title="$moveDown"><img src="$moveDownImage" width="11" height="11" alt="$moveDown" /></a>
836 - <img class="moveDownDisabled" src="$moveDisabledImage" width="11" height="11" />
 836+ <img class="moveDownDisabled" src="$moveDisabledImage" width="11" height="11" alt="" />
837837 <strong class="chapterTitle" style="margin-left: 0.5em;"></strong>
838838 <a class="renameLink" href="javascript:void(0)">[$rename]</a>
839839 </div>
@@ -1363,4 +1363,4 @@
13641364 return true;
13651365 }
13661366 }
1367 -
\ No newline at end of file
 1367+
\ No newline at end of file

Comments

#Comment by Brion VIBBER (talk | contribs)   04:56, 13 October 2008

It would be better to actually put something in there. :)

Status & tagging log